From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 624023FFF85; Tue, 21 Jul 2026 22:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673736; cv=none; b=noAw09qwUqbWjFBYkMjicdLA3oWBUxwqOzM/Yc7DtrW2n+GxxMsOwJseVBpufGRBly63jeBThksHRWIwY4KDw56SFvP59NMKSK6qwyElUttrAAbcLxU05ji2NEZAwnM3E3eiQ8Y1LEhwsObnntiszzmCFUxpjmoNR4zXFR1ZlYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784673736; c=relaxed/simple; bh=tkxg/Py4gO+iPz3t+PTuEhf4EQgGfqF3vHk26J0iA5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cb+SbCIL7Jn+etncWOWqxhkG9vP2+UDdHYHxa3/FEYwFsKHALK1Rbom3yFXKXZjyYJg3DTg7RdVW5tCXU93oJY6fourzZDoFZKfGkXx0NAmAuwoPC1mtrWvXFNeg4wFm8pHy/bnkOBhyuikiXc7OcwirmolttSCR1cd+LdURSvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gNrlv4eT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gNrlv4eT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE07E1F000E9; Tue, 21 Jul 2026 22:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784673735; bh=6eWOxQLF+evAWvZyjzgLYxpu00hObLiXQg4Y39Ij7lQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gNrlv4eTFBkITUqs2C9Pk01cuN93TxJwR08fpLgQ1OjjarYR9DLAu3DROKbB4iZ/Z JUr/NTDwe35HqztpCXWesDuEzNQ54XfLG2iYfQ/hCN6C7R3TqFQQnUsuLN0PT9HCd9 D/Pg0Zn14pUoZ1HzuE6nIgt+KLsDfilbBa9QXsOM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+64ec81389cbad56a8c35@syzkaller.appspotmail.com, Eric Dumazet , Jon Maloy , Tung Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 276/699] tipc: fix UAF in tipc_l2_send_msg() Date: Tue, 21 Jul 2026 17:20:35 +0200 Message-ID: <20260721152401.925000132@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit f4c3d89fc986b0da196ddfc6cfe0ea5d5d08bec6 ] Syzbot reported a slab-use-after-free in ipvlan_hard_header() when called from tipc_l2_send_msg(). The root cause is that tipc_disable_l2_media() calls synchronize_net() while b->media_ptr is still valid. This allows concurrent RCU readers to obtain the device pointer after synchronize_net() has finished. The pointer is cleared later in bearer_disable(), but without any subsequent synchronization, allowing the device to be freed while still in use by readers. Fix this by clearing b->media_ptr in tipc_disable_l2_media() before calling synchronize_net(). This is safe to do now because the call order in bearer_disable() was reversed in 0d051bf93c06 ("tipc: make bearer packet filtering generic") to call tipc_node_delete_links() (which needs the pointer) before disable_media(). Fixes: 282b3a056225 ("tipc: send out RESET immediately when link goes down") https: //lore.kernel.org/netdev/6a2c1007.428ffe26.258b27.015d.GAE@google.com/T/#u Reported-by: syzbot+64ec81389cbad56a8c35@syzkaller.appspotmail.com Signed-off-by: Eric Dumazet Cc: Jon Maloy Reviewed-by: Tung Nguyen Link: https://patch.msgid.link/20260612135949.4010482-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/tipc/bearer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index 69dfb043100858..7f4d825dc775df 100644 --- a/net/tipc/bearer.c +++ b/net/tipc/bearer.c @@ -469,6 +469,7 @@ void tipc_disable_l2_media(struct tipc_bearer *b) dev = (struct net_device *)rtnl_dereference(b->media_ptr); dev_remove_pack(&b->pt); RCU_INIT_POINTER(dev->tipc_ptr, NULL); + RCU_INIT_POINTER(b->media_ptr, NULL); synchronize_net(); dev_put(dev); } -- 2.53.0