From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98C6C39733E; Tue, 21 Jul 2026 22:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674451; cv=none; b=qCPHg6+ySj9ujC7s08Mu2PLkrofVW7tKjlw9X/BxyJb8iyM+7MnQk/mU/bP0nzrqsJzxHTqHuYzJj4KfrnWtn6yVtErS58nVN9UAsAiNyieuhbSU6EgD9b02JLgIyXFCmy6ZqpzcF3bMAMVIGCDcdM/ket5CxPR5QFBcxfZoeo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674451; c=relaxed/simple; bh=PMnycoPFYiOKAcjAzmNpTq4NL3hEQFvphm5FEO8b3bk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hHicn5SgqpcBRzj2kB24TsO2laHEXCUWRO9v6kyTqudnrVLIM1+fpGk2gkIX18R53I8W4DJa29KsL6T32l5gKxvuAbBefFxn/s0OlDTg0Vana4hbgBDysDtbyL1fWVyoS/HSjIIIko2pUbTi7ZAk0RT7HDo8Grhpqs7KXT828+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UtYjHQvb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UtYjHQvb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A9D61F00A3A; Tue, 21 Jul 2026 22:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674450; bh=V7kGqU9a7KIwW3pYpq2nU1ECuySsMDaAPwNtSMtHUII=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UtYjHQvbV4YRb5RecGiGhVkOnhJDhcrerKLz8R7xJsXRdJgy0UQlf5vAFX9RUefQ4 wBHapYbemcVvAI8HfiB6jx3XP+XRaW0LeVz8yBGwWwzR9iNyFih7ep/ZuonTswU/+u BRQyajC9Uu8XofzKFybUbHzCMNVVhkodxCjwOzE8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nico Yip , Oliver Hartkopp , stable@kernel.org, Marc Kleine-Budde Subject: [PATCH 5.10 503/699] can: isotp: use unconditional synchronize_rcu() in isotp_release() Date: Tue, 21 Jul 2026 17:24:22 +0200 Message-ID: <20260721152407.042101734@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Hartkopp commit 9b1a02e0d980ac6b0e36a90378f847062f81d7e4 upstream. isotp_notify() unregisters the (RCU) CAN filters via can_rx_unregister() and clears so->bound without waiting for a grace period. isotp_release() uses so->bound to decide whether it needs to call synchronize_rcu() before cancelling so->rxtimer, so when NETDEV_UNREGISTER runs first it skips that synchronize_rcu() and can cancel the timer while an in-flight isotp_rcv() is still executing and about to re-arm it via isotp_send_fc(), leading to a use-after-free timer callback on the freed socket. sakisho-bot remarked a problem with rtnl_lock held in isotp_notify(), therefore make isotp_release() always call synchronize_rcu() before cancelling the timers, regardless of so->bound. This still closes the original race (isotp_notify() clearing so->bound without waiting for in-flight isotp_rcv() callers before isotp_release() cancels the RX timer) without adding any RCU wait to the netdevice notifier path. Fixes: 14a4696bc311 ("can: isotp: isotp_release(): omit unintended hrtimer restart on socket release") Closes: https://lore.kernel.org/linux-can/20260707085210.6B6C01F000E9@smtp.kernel.org/ Reported-by: Nico Yip Signed-off-by: Oliver Hartkopp Link: https://patch.msgid.link/20260712-isotp-fixes-v10-1-793a1b1ce17f@hartkopp.net Cc: stable@kernel.org Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- net/can/isotp.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/net/can/isotp.c +++ b/net/can/isotp.c @@ -1184,11 +1184,18 @@ static int isotp_release(struct socket * SINGLE_MASK(so->txid), isotp_rcv_echo, sk); dev_put(dev); - synchronize_rcu(); } } } + /* Always wait for a grace period before touching the timers below. + * A concurrent NETDEV_UNREGISTER may have already unregistered our + * filters and cleared so->bound in isotp_notify() without waiting + * for in-flight isotp_rcv() callers to finish, so this call must not + * be skipped just because so->bound is already 0 here. + */ + synchronize_rcu(); + hrtimer_cancel(&so->txfrtimer); hrtimer_cancel(&so->txtimer); hrtimer_cancel(&so->rxtimer);