From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F2339733E; Tue, 21 Jul 2026 22:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674462; cv=none; b=fmNbjQJGcK3792nsAxD6K7DtTUKO16iX9m3d1KGd+SwxOtj2F/LqXm4oZGLcifOqZWHHsvQrzlxkAWE1NAewz+70GEW/z/f8X/6QSBoFAGbOWQ1Ge/4CUfqlV9ud4T2Y8GUSPMQt+xrJTFxO76N3HEdb3xT7FeStBIEV1XzowqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674462; c=relaxed/simple; bh=7V2CAI0Ij8VAcWeuRGeSIeDFilYCVKGV5hqwBCq7OiI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SwN5UA5jq907dap4bhx2qD+5a6YAYj0yYAlacmguH3tfDfqgp8Xp6i55NF99fphRkx8eWMJM67B60i/UF/XQYzYOcD7i8O+3dnhLRSo76plfgQJNXsqQLx8uZmFc2ECn7Mqjsba/3QImfEmMhvywNm0ehusu4iN5IC4iT486gHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bqDWGTws; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bqDWGTws" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAD5E1F00A3A; Tue, 21 Jul 2026 22:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674461; bh=yV6jBfqUzvpNFN52JFbL3uDbq+8YBdgE7viD2mMdHVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bqDWGTwsVQ4dFnyRez+/C6aefvlzJbbn0hlWgCaB5QhtRJgqpiOnZdSNe/IZku3o6 oojHdmr+8EoAwwEJNn0vAvcHRWAYaIekJIWRQhdVgT+djeaHCOB8JQt4MPL0T5YZ+n nqjUUrp/3f+g9066I6fH7nTi9BCEscf56ObRy9vY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Guenter Roeck Subject: [PATCH 5.10 551/699] hwmon: (asus_atk0110) Check package count before accessing element Date: Tue, 21 Jul 2026 17:25:10 +0200 Message-ID: <20260721152408.132286763@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An commit e2735b39f044bad7bf2017aef248935525bc0b97 upstream. atk_ec_present() walks the management group package returned by the GGRP ACPI method and, for each sub-package, reads its first element: id = &obj->package.elements[0]; if (id->type != ACPI_TYPE_INTEGER) without checking that the sub-package is non-empty. ACPICA allocates the element array with exactly package.count entries, so for a sub-package with a zero count this reads past the allocation. The sibling function atk_debugfs_ggrp_open() performs the same access but skips empty packages with a package.count check first. Add the same check to atk_ec_present() so a malformed firmware package cannot trigger an out-of-bounds read. Fixes: 9e6eba610c2e ("hwmon: (asus_atk0110) Enable the EC") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An Link: https://lore.kernel.org/r/20260619122746.721981-1-sammiee5311@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/asus_atk0110.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/hwmon/asus_atk0110.c +++ b/drivers/hwmon/asus_atk0110.c @@ -1037,6 +1037,9 @@ static int atk_ec_present(struct atk_dat if (obj->type != ACPI_TYPE_PACKAGE) continue; + if (!obj->package.count) + continue; + id = &obj->package.elements[0]; if (id->type != ACPI_TYPE_INTEGER) continue;