From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3407A430CE3; Tue, 21 Jul 2026 22:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674550; cv=none; b=ofpfIUiScxVj0tBwGywAQvN6fEu2+fOROd9BG3AcPxuGIgbz3KgRnsilbiImac3I7IRIw8+o9qkFchhwbHV7842KBHpdfGrrln7olWeH51WU4hd+ZP5SuYUgjzBBB0knvWjiyk1x+2beCN8Xd+FjlJTnmpUQBQJDKP0t3xf2xro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784674550; c=relaxed/simple; bh=UL7f0c0fMgPI2hLP2mMxUeWg+jrC9Pxg6k8+XraFBIE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rAWamcvhGBQIJLtpGZeOHYc7yPbpuK1Bk462olc98CTfi8F31wdQiAkxqA98+S4AMMlw7GBI0RXHBJlN52G+1PuVddA0jbBpXvkbSCN/uWLSU/4JNwS0n821fcHxrWu8TmEY33Sn1sWlw4MyouJXTzABDqvrl4wope+pzDbwtMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qqbxUNRY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qqbxUNRY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C3C61F000E9; Tue, 21 Jul 2026 22:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784674548; bh=4AotJZTM9kFDPI1QaDLohhYKTSZg6oKfJQi5PwpsHew=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qqbxUNRY8JoCdbH+IlU6PiMP3SOk1P4ft/CG27dXBUhbmEl5c7+yMc1/BYjzrQ8Z/ JBcJi1owX5o7/Ene9XZbUF9MPIdZytnPKtBGz1lYlkNZxFqKmsZbW/AulzaKok2pLW NGLNck18t22ideFcPbK7TOV/2glPhGV/X/MFob0Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Rafael J. Wysocki" , Dave Jiang , Sasha Levin Subject: [PATCH 5.10 581/699] ACPI: NFIT: core: Fix acpi_nfit_init() error cleanup Date: Tue, 21 Jul 2026 17:25:40 +0200 Message-ID: <20260721152408.821231994@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152355.667394603@linuxfoundation.org> References: <20260721152355.667394603@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: "Rafael J. Wysocki" [ Upstream commit 38bf27511ef41bffebd157ec3eba41fc89ba59cd ] If acpi_nfit_init() fails after adding the acpi_desc object to the acpi_descs list, that object is never removed from that list because the acpi_nfit_shutdown() devm action is not added for the NFIT device in that case. Next, the acpi_nfit_init() failure causes acpi_nfit_probe() to fail, the acpi_desc object is freed, and a dangling pointer is left behind in the acpi_descs. Any subsequent ACPI Machine Check Exception will trigger nfit_handle_mce() which iterates over acpi_descs and so a use-after-free will occur. Moreover, if acpi_nfit_probe() returns 0 after installing a notify handler for the NFIT device and without allocating the acpi_desc object and setting the NFIT device's driver data pointer, the acpi_desc object will be allocated by acpi_nfit_update_notify() and acpi_nfit_init() will be called to initialize it. Regardless of whether or not acpi_nfit_init() fails in that case, the acpi_nfit_shutdown() devm action is not added for the NFIT device and acpi_desc is never removed from the acpi_descs list. If the acpi_desc object is freed subsequently on driver removal, any subsequent ACPI MCE will lead to a use-after-free like in the previous case. To address the first issue mentioned above, make acpi_nfit_probe() call acpi_nfit_shutdown() directly on acpi_nfit_init() failures and to address the other one, add a remove callback to the driver and make it call acpi_nfit_shutdown(). Also, since it is now possible to pass NULL to acpi_nfit_shutdown() or the acpi_desc object passed to it may not have been initialized, add checks against NULL for acpi_desc and its nvdimm_bus field to that function and make acpi_nfit_unregister() clear the latter after unregistering the NVDIMM bus. Fixes: a61fe6f7902e ("nfit, tools/testing/nvdimm: unify common init for acpi_nfit_desc") Fixes: fbabd829fe76 ("acpi, nfit: fix module unload vs workqueue shutdown race") Signed-off-by: Rafael J. Wysocki Cc: All applicable Reviewed-by: Dave Jiang Link: https://patch.msgid.link/1963615.tdWV9SEqCh@rafael.j.wysocki Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/nfit/core.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -3456,6 +3456,8 @@ static void acpi_nfit_unregister(void *d struct acpi_nfit_desc *acpi_desc = data; nvdimm_bus_unregister(acpi_desc->nvdimm_bus); + /* The nvdimm_bus object may have been freed, so clear the pointer. */ + acpi_desc->nvdimm_bus = NULL; } int acpi_nfit_init(struct acpi_nfit_desc *acpi_desc, void *data, acpi_size sz) @@ -3680,7 +3682,10 @@ static void acpi_nfit_put_table(void *ta void acpi_nfit_shutdown(void *data) { struct acpi_nfit_desc *acpi_desc = data; - struct device *bus_dev = to_nvdimm_bus_dev(acpi_desc->nvdimm_bus); + struct device *bus_dev; + + if (!acpi_desc || !acpi_desc->nvdimm_bus) + return; /* * Destruct under acpi_desc_lock so that nfit_handle_mce does not @@ -3695,6 +3700,7 @@ void acpi_nfit_shutdown(void *data) mutex_unlock(&acpi_desc->init_mutex); cancel_delayed_work_sync(&acpi_desc->dwork); + bus_dev = to_nvdimm_bus_dev(acpi_desc->nvdimm_bus); /* * Bounce the nvdimm bus lock to make sure any in-flight * acpi_nfit_ars_rescan() submissions have had a chance to @@ -3762,13 +3768,14 @@ static int acpi_nfit_add(struct acpi_dev sz - sizeof(struct acpi_table_nfit)); if (rc) - return rc; - return devm_add_action_or_reset(dev, acpi_nfit_shutdown, acpi_desc); + acpi_nfit_shutdown(acpi_desc); + + return rc; } static int acpi_nfit_remove(struct acpi_device *adev) { - /* see acpi_nfit_unregister */ + acpi_nfit_shutdown(dev_get_drvdata(&adev->dev)); return 0; }