From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D63143D4EE; Tue, 21 Jul 2026 21:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671139; cv=none; b=JNHVBe8g+fsW6hCXYwRJmE9S3wgsWXxq/4YgvtjwTuYf0erM6qghPz+WgiS0vUQEN/I2OZSvkr96xRarhcedqgNmA2LcqXPw8Noq2yjdioX31tbKGIVVexbtFusanrdHG1/+0IrO+RCD4zXxk7o7UCAawDNdzXYyCCyMuZGY3aE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784671139; c=relaxed/simple; bh=4HGvdIvhydCI+OFz5NJZcn0UQcdwTvGqkC86TVEpYO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VsV4y5+D9cJDAONBH6R+xRcrwYIH8c80UBWbGP48+IWmUbKATlhNSU5r1P9ZXDeG5CoRLoZPUtxF9LO1XQThIB9kgrIep4YD1UjLKQiFIvoKL/84hWa3Hny1xabuF9tM4V2pv+k2frdpKjfB99VPWQ6+Mjovrrx6o3yEx9jwbfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dPnEaVQL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dPnEaVQL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E8581F000E9; Tue, 21 Jul 2026 21:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784671138; bh=Ll4BUBI5k1nvZpAzRWLHy70vGT7nCEvnB4QFkSERAJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dPnEaVQLoMfUEdalLMk/4rfIicTnjcbuZDqY1PpRjh8vDDcwgkuo6pK0fzyRAjFpe coQkKnaZXUpmMPSP1N714R9CIht4AlMIHthuREU8YxwU9nsFzJeNPtD6PsuGPmpRgm CZk/KAfUBH+3tBJ1R1PCWjkXw36xLnjycgrwkraM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexey Nepomnyashih , "Darrick J. Wong" , Allison Henderson , Carlos Maiolino Subject: [PATCH 5.15 126/843] xfs: fix unreachable BIGTIME check in dquot flush validation Date: Tue, 21 Jul 2026 17:16:01 +0200 Message-ID: <20260721152408.844227206@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152405.946368001@linuxfoundation.org> References: <20260721152405.946368001@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexey Nepomnyashih commit 03866d130ed33ab68cc7faaf4bf2c4abef96d42e upstream. The dqp->q_id == 0 check inside the XFS_DQTYPE_BIGTIME block is unreachable because root dquots return successfully earlier. Reject root dquots with XFS_DQTYPE_BIGTIME before that early return, preserving the intended validation and removing the unreachable condition. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4ea1ff3b4968 ("xfs: widen ondisk quota expiration timestamps to handle y2038+") Cc: stable@vger.kernel.org # v5.10+ Signed-off-by: Alexey Nepomnyashih Reviewed-by: "Darrick J. Wong" Reviewed-by: Allison Henderson Signed-off-by: Carlos Maiolino Signed-off-by: Greg Kroah-Hartman --- fs/xfs/xfs_dquot.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) --- a/fs/xfs/xfs_dquot.c +++ b/fs/xfs/xfs_dquot.c @@ -1202,6 +1202,14 @@ xfs_qm_dqflush_check( type != XFS_DQTYPE_PROJ) return __this_address; + /* bigtime flag should never be set on root dquots */ + if (dqp->q_type & XFS_DQTYPE_BIGTIME) { + if (!xfs_has_bigtime(dqp->q_mount)) + return __this_address; + if (dqp->q_id == 0) + return __this_address; + } + if (dqp->q_id == 0) return NULL; @@ -1217,14 +1225,6 @@ xfs_qm_dqflush_check( !dqp->q_rtb.timer) return __this_address; - /* bigtime flag should never be set on root dquots */ - if (dqp->q_type & XFS_DQTYPE_BIGTIME) { - if (!xfs_has_bigtime(dqp->q_mount)) - return __this_address; - if (dqp->q_id == 0) - return __this_address; - } - return NULL; }