From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C58F24A078; Tue, 21 Jul 2026 20:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664964; cv=none; b=gRX5Ss0RQLBVPySExgvzDz+oAgCDREbeILs1tYWDrmxZhjAx6e7QlPHP8p/cLoQI+IZBOJTqmuz/OFAGuQERj9rU/dfl7ZLly1ban71M5XY7GwVf1ik9vi5XxZVMy+qBnBR1R3+x7JdbGvx7RH1HrdfrVjw7GiIgbDNpfVIfzYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664964; c=relaxed/simple; bh=3wdvep4yFVDEZOgV/fhBANi2z4GmHf+uNOPa8cyeJoA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V6T5Vu1wDT32LXGjMeJFw/g6JJq1sa+4aoY2VjHNB/5U2tU+6MWJ66ZFLkWIh6K4FogSjHwOUPYVVWjghUG5pXijjy6wLtI4d0IxcMeu0AqAslQ8I7u7VEIKycDxxyveyAIjnDxx0MNfM7HhBwSLqpnYrCylP8wVQ58XAM9JzMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Il9KtCGj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Il9KtCGj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78B8C1F000E9; Tue, 21 Jul 2026 20:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784664963; bh=vZ/cmRGNATBe26+0GB6mrpeTWs19hhm2aGOh56Iln64=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Il9KtCGjmYDZT4A9DfahOmprFIJa3tX4TJ99g84YfCpPeptP1cl082zQzzWdd8Ywo ovainNTn4RanVrF8OjrXg8ZSJFNwj02RPdaj1DkE5BfbvHZVNgPBpfUtgPlT+eCmIy HX3GKhYpgIcfZCrQml4ZiTkAaghH3BFi5XAKy5LE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rajat Jain , Johan Hovold , Luiz Augusto von Dentz Subject: [PATCH 6.6 0124/1266] Bluetooth: btusb: fix use-after-free on marvell probe failure Date: Tue, 21 Jul 2026 17:09:21 +0200 Message-ID: <20260721152444.577924109@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit c5b600a3c05b1a7a110d558df935a8fc8a471c79 upstream. Make sure to stop any TX URBs submitted during Marvell OOB wakeup configuration on later probe failures to avoid use-after-free in the completion callback. This issue was reported by Sashiko while reviewing a fix for a wakeup source leak in the btusb probe errors paths. Link: https://sashiko.dev/#/patchset/20260402092704.2346710-1-johan%40kernel.org Fixes: a4ccc9e33d2f ("Bluetooth: btusb: Configure Marvell to use one of the pins for oob wakeup") Cc: stable@vger.kernel.org # 4.11 Cc: Rajat Jain Signed-off-by: Johan Hovold Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/btusb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3894,7 +3894,7 @@ static int btusb_probe(struct usb_interf if (id->driver_info & BTUSB_INTEL_COMBINED) { err = btintel_configure_setup(hdev, btusb_driver.name); if (err) - goto out_free_dev; + goto err_kill_tx_urbs; /* Transport specific configuration */ hdev->send = btusb_send_frame_intel; @@ -4052,7 +4052,7 @@ static int btusb_probe(struct usb_interf err = usb_set_interface(data->udev, 0, 0); if (err < 0) { BT_ERR("failed to set interface 0, alt 0 %d", err); - goto out_free_dev; + goto err_kill_tx_urbs; } } @@ -4060,7 +4060,7 @@ static int btusb_probe(struct usb_interf err = usb_driver_claim_interface(&btusb_driver, data->isoc, data); if (err < 0) - goto out_free_dev; + goto err_kill_tx_urbs; } if (IS_ENABLED(CONFIG_BT_HCIBTUSB_BCM) && data->diag) { @@ -4096,6 +4096,8 @@ err_release_siblings: usb_set_intfdata(data->isoc, NULL); usb_driver_release_interface(&btusb_driver, data->isoc); } +err_kill_tx_urbs: + usb_kill_anchored_urbs(&data->tx_anchor); out_free_dev: if (data->reset_gpio) gpiod_put(data->reset_gpio);