From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75114347512; Tue, 21 Jul 2026 20:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665266; cv=none; b=NgRYeb/lxlmkQ5wbgXPTixIlR+KT5DuokpRkpj39JTsLBJ/wGwKeNU/KDrfG4mDL5jzItk009skLuv17YPoXCmuEI8QCgsFcA0vfPHQ1O5p1aUGx3E/ytGbFef7iLUpxRrijQrIvF7TLWDli3hM7hxhcwr6v20GYmN4n0ivdZk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665266; c=relaxed/simple; bh=HIlsegvY7yUHz3VBDoKgjRbkq5zdZRrcNz3uOukEPZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N8yrO24DWL8menN2KATOIiXvGr+1zFWbYM9UrJB4iC+RPu11+S007MPc/RudgQiNk4/0utQjJu7T90iN91p9qpeizzgvzw9TAhsJtiucnqsW0CbKg45v5Z/FbE3ZpbKPO/E93XX3CDi/ijiP15lNH0ZimYLm5eqagx7TcXZc8cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cGU/EMir; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cGU/EMir" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2591F00A3A; Tue, 21 Jul 2026 20:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784665265; bh=UBMfYkhsaMduzw+xFZdDBXrHNehNsDruoH2KngDVtnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cGU/EMir/Iq77xK4C0sJOFkV+Ok1AeLJI1al5MjRfsAGVwBXkhVpJg32p/TjNpewo A/zWWw1pPtd0Q+fpHltTI9tI54lZiC1wxG/om7koaFxZBuEbBn8SebJGRxE5mPQXZb zw6fpoRXvMj918oRKhecLkpbpOYpT914pKYEhiXk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Ijae Kim , Myeonghun Pak , Alex Henrie Subject: [PATCH 6.6 0240/1266] USB: misc: uss720: unregister parport on probe failure Date: Tue, 21 Jul 2026 17:11:17 +0200 Message-ID: <20260721152447.187716301@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak commit b4ecbdc4f8830f5586c4a5cfc384c00f20f8f8b3 upstream. uss720_probe() registers a parport before reading the 1284 register used to detect unsupported Belkin F5U002 adapters. If get_1284_register() fails, the error path drops the driver private data and the USB device reference, but leaves the parport device registered. Leaving the port registered is more than a private allocation leak: parport_register_port() has already reserved a parport number and registered the parport bus device, while pp->private_data still points at the private data that the common error path is about to release. Undo the pre-announce registration in the get_1284_register() failure branch before jumping to the common private-data cleanup path. Clear priv->pp first, matching the disconnect path and avoiding a stale pointer in the private data. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 3295f1b866bf ("usb: misc: uss720: check for incompatible versions of the Belkin F5U002") Cc: stable Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Reviewed-by: Alex Henrie Link: https://patch.msgid.link/20260706151049.63470-1-mhun512@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/uss720.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -732,8 +732,11 @@ static int uss720_probe(struct usb_inter * here. */ ret = get_1284_register(pp, 0, ®, GFP_KERNEL); dev_dbg(&intf->dev, "reg: %7ph\n", priv->reg); - if (ret < 0) + if (ret < 0) { + priv->pp = NULL; + parport_del_port(pp); goto probe_abort; + } ret = usb_find_last_int_in_endpoint(interface, &epd); if (!ret) {