From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CC6B472531; Tue, 21 Jul 2026 20:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665407; cv=none; b=AOQy7SxCMis7FQ190fTMlg+4RnMaUlJw2zOfLEbfF+bqWzFJrlTuzMPPPkgdN7HwpNjuIpmnWzqL4lI8q6ztbzowE1Jp5tTAq0XW4MOmMahpSbPI6/uI6ENYSy94LwZmUP5Q7Fz6VNoVNNpM+hoEn03EHzbNFRLb6O+N0FGWRV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665407; c=relaxed/simple; bh=VfHnpMXhgezRQ0shPEi/lnY/kH+OKemzKjrf6LQfpOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cft0a9gS6NlSRE4LpXNApyfzpS5Zd6pSJzw7v52jtGTU/DtrTMfsUxRydOaqo/usqshItkh7sB0cu5dV9UYvOGEVtBGjBZGU8/wEDWJK3DznxB10d639YUp8/vyrjhTocx81SidwgK9Jyqmsi5Bv9uG/Cy0D4Hx5IvXz2saMEew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uNQ9lvpe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uNQ9lvpe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADD2D1F000E9; Tue, 21 Jul 2026 20:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784665406; bh=WH/vuQ7D7kCpeEIJVfiZknyXTgIMyAOXM31XLkajgpY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uNQ9lvpeO91LjFlOFYe4iTGQaSR+2CDPy7Txy8Y1rjgW67z33rHp0T41/iL4AITfx iTM3eai12GQhv3qWxdrV2pV1Q8WgMebShXrCPPmf/6lPteZCpsxd5DRNS/VVnOHJz2 8DFRsGe5AqBkw3MA9g5vMs3ihx15xnXJkKn/s0aQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vasily Khoruzhick , Tony Luck , Qiuxu Zhuo Subject: [PATCH 6.6 0292/1266] EDAC/i10nm: Dont fail probing if ADXL is missing Date: Tue, 21 Jul 2026 17:12:09 +0200 Message-ID: <20260721152448.356988349@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vasily Khoruzhick commit e360a6d65bb46c527a5909430a31d640cdd5036e upstream. ADXL is not present in Coreboot- or Slimbootloader-based BIOSes and as result, the driver fails to probe there. Since commit 2738c69a8813 ("EDAC/i10nm: Add driver decoder for Ice Lake and Tremont CPUs"), i10nm_edac supports driver decoder. Switch to driver decoding when ADXL is not present. Signed-off-by: Vasily Khoruzhick Signed-off-by: Tony Luck Reviewed-by: Qiuxu Zhuo Cc: stable@vger.kernel.org # v6.1+ Link: https://patch.msgid.link/20260414181735.87023-1-anarsoul@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/edac/i10nm_base.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) --- a/drivers/edac/i10nm_base.c +++ b/drivers/edac/i10nm_base.c @@ -88,6 +88,7 @@ static struct res_config *res_cfg; static int retry_rd_err_log; static int decoding_via_mca; static bool mem_cfg_2lm; +static bool no_adxl; static u32 offsets_scrub_icx[] = {0x22c60, 0x22c54, 0x22c5c, 0x22c58, 0x22c28, 0x20ed8}; static u32 offsets_scrub_spr[] = {0x22c60, 0x22c54, 0x22f08, 0x22c58, 0x22c28, 0x20ed8}; @@ -1173,8 +1174,14 @@ static int __init i10nm_init(void) } rc = skx_adxl_get(); - if (rc) - goto fail; + if (rc) { + /* Decoding errors via MCA banks for 2LM isn't supported yet */ + if (rc != -ENODEV || mem_cfg_2lm) + goto fail; + i10nm_printk(KERN_INFO, "ADXL not found, falling back to MCA-based decoding.\n"); + no_adxl = true; + decoding_via_mca = true; + } opstate_init(); mce_register_decode_chain(&i10nm_mce_dec); @@ -1208,7 +1215,8 @@ static void __exit i10nm_exit(void) teardown_i10nm_debug(); mce_unregister_decode_chain(&i10nm_mce_dec); - skx_adxl_put(); + if (!no_adxl) + skx_adxl_put(); skx_remove(); }