From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 030A946AA69; Tue, 21 Jul 2026 20:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665707; cv=none; b=r8cDT4/DF4fFTqZEy5neqSspJscl2ptV8ZjzS8de3kGLnYb5FGaMGPNiD595++ivepaCG8SN387il7l9JVOJshj45RQy1qzvVmRqYFp/2UfEtvOn1OjuwQbNu1AzqNvUk7UmMU6MlPv1dKcDDWBNxpYSSQE7rAA/u+p8+OzKxDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665707; c=relaxed/simple; bh=xwBJuM4f7Rai01FAME1pIdKPyfJ9WfZLDtFkz9XCSdM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HvqnkE2jJeXt1kgkNmRmEfkSd78S/EWM9lFylTWWV1EESXcrTVQPTcyL7HcKwSGlSXAjNoxk6fW2TCHHjY155kH2cjcFlzp40JfzamyWL29GlGs2D6/LV70LpYGT0geP+v/QlwIslJpWVPSGzD1++GEI9xvMr/2TLK6kEh8VpHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aNDIwPvV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aNDIwPvV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10EFC1F00A3D; Tue, 21 Jul 2026 20:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784665705; bh=hdvD9HcxiAi1yNpjqharJBZpO0tBTqP5O7EIaO0zrxo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aNDIwPvVrSOfgESaEJthprpomN78o60glIHFAAdQvSxXy5Gaj/0dN74xSjKD5oePx Ayw/y/wp95W1QBqfgTvYcJ0AQY1YWv/4zwebBzj7Q9xaKEbWt4Lc1Kv8DX0lVb038j 3AEGC4bxuSIOi3oAyTGMHUAU6jwvYWm1w+CntB6o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Louis Kotze , Johannes Berg , Sasha Levin Subject: [PATCH 6.6 0368/1266] wifi: cfg80211: fix grammar in MLO group key error message Date: Tue, 21 Jul 2026 17:13:25 +0200 Message-ID: <20260721152450.061903368@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Louis Kotze [ Upstream commit 9dcc1af3bbf5441f71a1e51b8d81bdf38a249607 ] The error message emitted by nl80211_validate_key_link_id() when a group key install on an MLO wdev is missing the link ID reads "link ID must for MLO group key", which is missing the words "be set". This makes the error harder to grep and parse in userspace logs, and is reported verbatim by wpa_supplicant via its nl80211 extack relay, e.g.: wpa_supplicant: nl80211: kernel reports: link ID must for MLO group key The sibling error strings in the same helper already use grammatical phrasing ("link ID not allowed for pairwise key", "invalid link ID for MLO group key", "link ID not allowed for non-MLO group key"). Fix this one to match. No functional change. Fixes: e7a7b84e3317 ("wifi: cfg80211: Add link_id parameter to various key operations for MLO") Signed-off-by: Louis Kotze Link: https://patch.msgid.link/20260414122728.92234-1-loukot@gmail.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 9f2e84af6f8b46..e4a490d12b504e 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -4456,7 +4456,7 @@ static int nl80211_validate_key_link_id(struct genl_info *info, if (wdev->valid_links) { if (link_id == -1) { GENL_SET_ERR_MSG(info, - "link ID must for MLO group key"); + "link ID must be set for MLO group key"); return -EINVAL; } if (!(wdev->valid_links & BIT(link_id))) { -- 2.53.0