From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3270403B13; Tue, 21 Jul 2026 20:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665645; cv=none; b=ANJqNJ1YMFj/W/Ntmpdh0zUIR6BXM/Hhx14BioqIfPcV45B650Up4+NReP7WT1U6iM7KdUAKE01xzKzCEvNCF5JeQrYKC1E3zmra/HBglNfqEDGKJSWmEaNvJc8sRG1gyus5nSAbG3PAWJA9Qt2R3cP3/TDxcg738YDJTa/36LI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665645; c=relaxed/simple; bh=40RaXq1eYcRDVXcB/yTMfv98+jp/t1J5DLkPju6ra70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T/o8edrVIjhjDWMaV0goQjG1vCw1o8yPvD8IST2OYeoMjnF5mmrS98vjHuM586+y84nNaWIki8iM7GVW8CNg/n+k3LHlU0hEuHqbQSEsviC1daCiJ7nTD0tGPfXflUoYgRn3zSqCqqZUByA4I6kjViTSwOLIOeNgskcKnzjE/Ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1vnw42Su; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1vnw42Su" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1324E1F000E9; Tue, 21 Jul 2026 20:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784665644; bh=s9sROWNFU9T0TvlAYbKcUh5nRh8bWCA3zAzEwn0/W00=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1vnw42SuLkdhg5gBjm3xlkgRAYLtH3StxynvB7nwMuhdB9QUSoxnXlwLVtqLAYFAx M0ZWlu8NRr1rz+HCkJftzt0MiommgmD3xUJeQIUfwbdauoCNgXD5F7mJWGdD0TJS7T Y3DjQBalv26dYlK5j08VTNuM1ma/IQXVZLeNXTis= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Gu , Andre Przywara , Linus Walleij , Sasha Levin Subject: [PATCH 6.6 0383/1266] pinctrl: sunxi: fix regulator leak in sunxi_pmx_request() error path Date: Tue, 21 Jul 2026 17:13:40 +0200 Message-ID: <20260721152450.395500055@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Gu [ Upstream commit 334f7bcbdc79dc8e5b938ac3372453a5368221cf ] In the error path of sunxi_pmx_request(), the code calls regulator_put(s_reg->regulator) to release the regulator. However, s_reg->regulator is only assigned after a successful regulator_enable(). This causes a memory leak: the regulator obtained via regulator_get() is never properly released when regulator_enable() fails. Fixes: dc1445584177 ("pinctrl: sunxi: Fix and simplify pin bank regulator handling") Signed-off-by: Felix Gu Reviewed-by: Andre Przywara Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index fc11c3d55fa8c0..c5b954c9537dbc 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -880,7 +880,7 @@ static int sunxi_pmx_request(struct pinctrl_dev *pctldev, unsigned offset) return 0; out: - regulator_put(s_reg->regulator); + regulator_put(reg); return ret; } -- 2.53.0