From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 496491D7E5C; Tue, 21 Jul 2026 20:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665757; cv=none; b=bPu4FkV5a1DPipgpszj9nTWnQywbelgn4X8Qa8DYLtvbpbhUvcaMgUBZ+xtQPw+qPFmrZ4eDmho87iQJwp3YUv5jw2a9DEtrbAwplSwiSYB9VsvPOMiFa3URnVCX0s3Pz6t6uPPdXxwvX1vk9Y/A8aMXxNJoaaY119Z0pDFDwis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665757; c=relaxed/simple; bh=0odzdSZU1MSUt8R5gGyqjavQYGHo3bHYVk4ZqCOt0Dw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o8ojtGuDf3oULPKy722B4K5Ms0Ctbw5RjsXo2aR+iccCP2yFAu4J3bMqhJ1GWjHbiJdgvw+tLeEGWk5p7vULkyU0xWJRZ2d29GGBXC8g4NpBjfcCYvwvhymA+Q8JGkhTh4qbWNT8o2phHZncRqu1H5IBS9tHv3brL64rxc/s8tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RLMo/VCw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RLMo/VCw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7869D1F000E9; Tue, 21 Jul 2026 20:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784665756; bh=zYnvnyQmz/pSmHMKbHvafiwcjzIcDAHDqlJ20g76cOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RLMo/VCweLwhqhKBx6Yf1oS5bfWytTKbJJCl40A4Q9uK8s+ktXAhNEtkfnqOFaSnk nNLfHE++7sJ3r5zacFjXuGy7xgmC+9LkTXv+xGqU7dHIshvwB1ehO1ItTYaZnJ1rOK AWRCh+K7VFydq/z5aIt6AzTFMkZ4aB48gW68YQCE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lifeng Zheng , Viresh Kumar , Zhongqiu Han , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.6 0425/1266] cpufreq: conservative: Simplify frequency limit handling Date: Tue, 21 Jul 2026 17:14:22 +0200 Message-ID: <20260721152451.351461723@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lifeng Zheng [ Upstream commit 3494dff89779b73a6c70481c982e0e96d336454a ] cs_dbs_update() performs explicit checks against policy->min/max before updating the target frequency. These checks are redundant as __cpufreq_driver_target() already clamps the requested frequency to the valid policy limits. Remove the unnecessary boundary checks and simplify the update logic. This also fixes an issue introduced by commit 00bfe05889e9 ("cpufreq: conservative: Decrease frequency faster for deferred updates"), where stale target comparisons could cause frequency updates to be skipped entirely after deferred adjustments. Closes: https://lore.kernel.org/all/20260421123545.1745998-1-zhenglifeng1@huawei.com/ Fixes: 00bfe05889e9 ("cpufreq: conservative: Decrease frequency faster for deferred updates") Signed-off-by: Lifeng Zheng Co-developed-by: Viresh Kumar Signed-off-by: Viresh Kumar Reviewed-by: Zhongqiu Han Link: https://patch.msgid.link/292e6d937890f135e30ec0d2107eaad47cb9a976.1779423281.git.viresh.kumar@linaro.org Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/cpufreq_conservative.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c index efdcc4ab43340a..24fbb7313c9500 100644 --- a/drivers/cpufreq/cpufreq_conservative.c +++ b/drivers/cpufreq/cpufreq_conservative.c @@ -103,10 +103,6 @@ static unsigned int cs_dbs_update(struct cpufreq_policy *policy) if (load > dbs_data->up_threshold) { dbs_info->down_skip = 0; - /* if we are already at full speed then break out early */ - if (requested_freq == policy->max) - goto out; - requested_freq += freq_step; if (requested_freq > policy->max) requested_freq = policy->max; @@ -124,13 +120,7 @@ static unsigned int cs_dbs_update(struct cpufreq_policy *policy) /* Check for frequency decrease */ if (load < cs_tuners->down_threshold) { - /* - * if we cannot reduce the frequency anymore, break out early - */ - if (requested_freq == policy->min) - goto out; - - if (requested_freq > freq_step) + if (requested_freq > policy->min + freq_step) requested_freq -= freq_step; else requested_freq = policy->min; -- 2.53.0