From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF1DC49620; Tue, 21 Jul 2026 20:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666751; cv=none; b=me/1vwwJV3izcofJONjrU8aQQjQiD+YrZODk8O1HV4N4gKeG0gCneHEoLR+1S4euxd5wPHHp01Xdd5M3DLiGQwA8UVZSPJKlRpsLKc1o6lTPt5cgONd68WtQTdKdD4DbR0XgZql4fiofqjEL5efR+yKHSSEV7vgMq1dSWCckliU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666751; c=relaxed/simple; bh=Ajw5oZm04c5TzAXCzDWcIa5mCOehBJUUZnjWEj7QPys=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NL3fZt6fCRmWtspGkNWbLeI3xIbtbw9xVaYsWUuqGrcC5ydwoHXocjWAFaU/BZrJMmE/AuajaGudIvokDsjOK0AvBQwClANOzMYSmlecw+rAAeKiOWUCWWIFAurI09TSLOZGtcTOk6UQ/HOfkDloy6RmUjbpvXYTriO1J/YQQhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PTQ/nuJn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PTQ/nuJn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60C501F000E9; Tue, 21 Jul 2026 20:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784666749; bh=CqG/WuJVUNs6O+qaHldAAmswqKbrZsZMjAtQFFpYZhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PTQ/nuJnzD/9ED3nyb164NfdWNjvCvBrwo6A4UTIt3RwOD9RHXLGE3oL8SiF6v9fh dRgqDmf6rJx9/+SBCHIzChbtHZ8bSKJP8kuSzyfDACplbDNP2IybA3pt3KgEPHTNAr IGsm2TvAyB85KtdlTi2bvkZQAuIIxY9QBEfNvwYw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.6 0801/1266] gpio: mvebu: fail probe if gpiochip registration fails Date: Tue, 21 Jul 2026 17:20:38 +0200 Message-ID: <20260721152459.781832193@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 479e91fc92416a4d54d2b3150aa1e4550d9cc759 ] mvebu_gpio_probe() registers the GPIO chip with devm_gpiochip_add_data() but ignores the return value. If registration fails, probe continues and leaves later code operating on a GPIO chip that was never published to gpiolib. Return the registration error so the device fails probe cleanly. Fixes: fefe7b092345 ("gpio: introduce gpio-mvebu driver for Marvell SoCs") Signed-off-by: Pengpeng Hou Link: https://patch.msgid.link/20260624131645.86884-1-pengpeng@iscas.ac.cn Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-mvebu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index ee184720de57c2..9ca659cff43883 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1232,7 +1232,10 @@ static int mvebu_gpio_probe(struct platform_device *pdev) BUG(); } - devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip); + err = devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip); + if (err) + return dev_err_probe(&pdev->dev, err, + "failed to register gpiochip\n"); /* Some MVEBU SoCs have simple PWM support for GPIO lines */ if (IS_REACHABLE(CONFIG_PWM)) { -- 2.53.0