From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4918249620; Tue, 21 Jul 2026 20:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666841; cv=none; b=MfdacPqbgpgwrnT6pcRxJaZUICk64yakkfvmRkwkc6uyO9mlKa+RYfN6EIy9670PTGXHNSI/p1Dc8wfxo1vZvVQytP2+P3oL+81NbXWzWbkWMnRKhRegX0ZuLA6JhEn7w7K7KgCSMmOwDBpwNbXtHIQ+xqgxL83oQhJPay37BqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666841; c=relaxed/simple; bh=cncW2px3xUXBGWieRFmAYfr6jIwLE2xaf4iNqBtjtxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=toWCrn7aeFjZAuWtXnKrsRpp6uKbtu/QCFIX9qs/nQRMYFsKqWEb8/ooZcZT3t3q4JKDMUUKM4CWtJEl7PnbaTrEAeReq5y6WR/tZ3T02ItUNx2R3b1vgNFgUHdnSQsMKUSlBFeqaHtAYxRWoRlAAqbfOgrNG++R1OU8UcDr8jE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=b9OItsFR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="b9OItsFR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 810EF1F000E9; Tue, 21 Jul 2026 20:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784666840; bh=2fAmOs84Hoi6609NDANnPivcztUGTdX12mB4xl6gtHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b9OItsFRkcT4s7KoicaTvq57efYFGew+w+Dyrvs2pjA4DwFyi2Fhrk4u+PY+ZY204 /DyjcVC59NDPglOfvMan6qQH0OzfLq3sibj9bLSiDImfszcLIxD9Vu8Kot51tnagvP mPsiNCQvmRk+YNBFGxbTTpW1UaQycdpGutTETB70= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , Niklas Cassel , Linus Walleij , Damien Le Moal , Sasha Levin Subject: [PATCH 6.6 0836/1266] ata: sata_gemini: unwind clocks on IDE pinctrl errors Date: Tue, 21 Jul 2026 17:21:13 +0200 Message-ID: <20260721152500.562345814@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152441.786066624@linuxfoundation.org> References: <20260721152441.786066624@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak [ Upstream commit c0ace4130e813acbabdfaa28d4e94a849c2ffdd7 ] gemini_sata_bridge_init() prepares and enables both SATA PCLKs, then disables them again while keeping the clocks prepared for later bridge start and stop operations. If gemini_setup_ide_pins() fails after that, gemini_sata_probe() returns directly and skips the existing out_unprep_clk unwind path. Route the IDE pinctrl failure through out_unprep_clk so the clocks prepared by gemini_sata_bridge_init() are unprepared before probe fails. Fixes: d872ced29d5f ("ata: sata_gemini: Introduce explicit IDE pin control") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Reviewed-by: Niklas Cassel Reviewed-by: Linus Walleij Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/sata_gemini.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c index 4c270999ba3ccd..22a30c1d88863a 100644 --- a/drivers/ata/sata_gemini.c +++ b/drivers/ata/sata_gemini.c @@ -385,7 +385,7 @@ static int gemini_sata_probe(struct platform_device *pdev) if (sg->ide_pins) { ret = gemini_setup_ide_pins(dev); if (ret) - return ret; + goto out_unprep_clk; } dev_info(dev, "set up the Gemini IDE/SATA nexus\n"); -- 2.53.0