From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DBCF47010C; Tue, 21 Jul 2026 19:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784663476; cv=none; b=jeiCMNlZkuRi7uXaMjM3Ck3L93dBCgLR1pzPm0SMYlq/0NsLBWwQgYHKq/XhB0JGlHhoAvaw6OCIrPW6Njfxd9V7c399gk5nOLksv/BWKi78tjD0XcGo/R2LI6rvWrCS4owkmtJ1h7JFWRce8mtdAC9fKEx1V7lfJp7wIUN41Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784663476; c=relaxed/simple; bh=8bxhRSKf5rt0qi7e2tGLFWJtpxM4f4yHFXZPyN5CpTs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pdNRtO0sPBg2eGZa6hZRVLmOtBCP9OLNbmTTGgEKEiJEgHJrzCrTz+5XuNRtkBv1dBZCucqsrMo88ziIcaE4DBoW+2OtzH7xZzjAob1rGjxCwvcstOv6PLnLoXhj40qJmWxC6hMHI0l89IO+M1gZePMjgw53tZiiotmAAo1gZF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lxWT1L3F; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lxWT1L3F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E3E11F000E9; Tue, 21 Jul 2026 19:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784663475; bh=BtkkhlcV9mItPTEu+E+rdDx7ko2mAL8itcZ+s070lMg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lxWT1L3FpgL7Tz2iguCqHzdfrUjOpWnn5pzFD8iDLJJkssWASXT3wclLZzqRD440J LMQlRxoKu7wNSRW04aNGh0M3DELZaWLFfkg0UItqkp6ABhTQ46SeNA9Ik+2egvY8KW FikHeRnltwU4Qf5h3DnR7I20s0kUuwG6XFXuZteo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdun Nihaal , Thomas Zimmermann , Helge Deller Subject: [PATCH 6.12 0838/1276] fbdev: metronomefb: fix potential memory leak in metronomefb_probe() Date: Tue, 21 Jul 2026 17:21:21 +0200 Message-ID: <20260721152504.810099847@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152446.065700225@linuxfoundation.org> References: <20260721152446.065700225@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdun Nihaal commit 894632b862a39b3fe1cb5de06fbae86225ea64de upstream. The memory allocated for pagerefs in fb_deferred_io_init() is not freed on the error path. Fix it by calling fb_deferred_io_cleanup(). Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal Reviewed-by: Thomas Zimmermann Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/metronomefb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/metronomefb.c +++ b/drivers/video/fbdev/metronomefb.c @@ -645,12 +645,14 @@ static int metronomefb_probe(struct plat info->flags = FBINFO_VIRTFB; info->fbdefio = &metronomefb_defio; - fb_deferred_io_init(info); + retval = fb_deferred_io_init(info); + if (retval) + goto err_free_irq; retval = fb_alloc_cmap(&info->cmap, 8, 0); if (retval < 0) { dev_err(&dev->dev, "Failed to allocate colormap\n"); - goto err_free_irq; + goto err_fbdefio; } /* set cmap */ @@ -673,6 +675,8 @@ static int metronomefb_probe(struct plat err_cmap: fb_dealloc_cmap(&info->cmap); +err_fbdefio: + fb_deferred_io_cleanup(info); err_free_irq: board->cleanup(par); err_csum_table: