From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EA3146D2DA; Tue, 21 Jul 2026 17:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655532; cv=none; b=tc80aWIIjeaw3wSUkw4MsykDKErJPgpu0wEKR7/Dd7PJhm4wrctrrDOghMygQKdQDWSWQ5kxhA1QtXfZdRkMlTS/eo0F8ejC7NHYh+Mst4kbm6xG++XNeP2b9sulAmtKsNO8IK/bwpoOt/9i8exRVQpsTVEUQJIWY4oVqjuDoBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784655532; c=relaxed/simple; bh=juLgxZAqUyE1t8AbiqfBzVEnCj+F6cnZAJCLMyS6yKA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JoSDSxT2sg51j31SCxjIejhN2pqpk8YSOwqDkY9f9u27Zuxd4UxPi2u4bgaT2lnRvgtEueY1hQOqn/sMw+Kx96WSlar+ZFhMx+8LlQvfKubUJsatB4TCN7CUntqF6c+CmM42W7L6sPpCigCPnG+SbqbfMC0qsY8cu3a395qbqFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wJoyiMGA; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wJoyiMGA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E2421F000E9; Tue, 21 Jul 2026 17:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784655530; bh=C6nFy9HQzZ66wn68UTll26HNqWKCjoq/LXXd2G/bemo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wJoyiMGA8L/RVKB/moLCJcatPn9eBD3egCr6omHMSduE3k/B5AUdhIcCZlWZ0QLT3 iLk7YW9Cj4PCDHS1YMBtnHl84+bP2b7wI0T+xvLt4eQ7sfrRrNsMprLzx5NJIqs2Qx mkRfW8daS2zFA+Vd1HEJ/7okUxmhDGUmbja90i9I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christoph Hellwig , Shivam Kumar , Keith Busch Subject: [PATCH 6.18 0007/1611] nvmet-tcp: check INIT_FAILED before nvmet_req_uninit in digest error path Date: Tue, 21 Jul 2026 17:02:03 +0200 Message-ID: <20260721152514.943014810@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shivam Kumar commit 4606467a75cfc16721937272ed29462a750b60c8 upstream. In nvmet_tcp_try_recv_ddgst(), when a data digest mismatch is detected, nvmet_req_uninit() is called unconditionally. However, if the command arrived via the nvmet_tcp_handle_req_failure() path, nvmet_req_init() had returned false and percpu_ref_tryget_live() was never executed. The unconditional percpu_ref_put() inside nvmet_req_uninit() then causes a refcount underflow, leading to a WARNING in percpu_ref_switch_to_atomic_rcu, a use-after-free diagnostic, and eventually a permanent workqueue deadlock. Check cmd->flags & NVMET_TCP_F_INIT_FAILED before calling nvmet_req_uninit(), matching the existing pattern in nvmet_tcp_execute_request(). Reviewed-by: Christoph Hellwig Signed-off-by: Shivam Kumar Signed-off-by: Keith Busch Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/target/tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/nvme/target/tcp.c +++ b/drivers/nvme/target/tcp.c @@ -1344,7 +1344,8 @@ static int nvmet_tcp_try_recv_ddgst(stru queue->idx, cmd->req.cmd->common.command_id, queue->pdu.cmd.hdr.type, le32_to_cpu(cmd->recv_ddgst), le32_to_cpu(cmd->exp_ddgst)); - nvmet_req_uninit(&cmd->req); + if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED)) + nvmet_req_uninit(&cmd->req); nvmet_tcp_free_cmd_buffers(cmd); nvmet_tcp_fatal_error(queue); ret = -EPROTO;