From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B14F8470421; Tue, 21 Jul 2026 17:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784656464; cv=none; b=b9d/brgSMlHje1EZR3OpmtewYTWjoNGk/KxHf6MqFnAuDUp8gPMeGJ7xBYETAaNyVVxz2JVQ6TTCqGQnc2owNc0/35+dw2H3XXRrF373VDFFKS6+neLUUkmTBwfFUs6BVk4bb2bj9On5MEwkvk9/8jluPId/8Z63BAL0OfJ+Y3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784656464; c=relaxed/simple; bh=zOuMPaFs5J6CI5I+en/VBd4qGss/aYymPl98Pxx3kcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GpBelHVajCFlFOnJHoyiKkIgWnZ5Hg1HXQbwAvidp0z+lRo0EMBSmH3VlDqwqYLJYhZJo2vzbCRVTECS7YCaHiIZIYcWhUvLuLYhO6uC7eSQ/SrQ2oAcRg/celrXNGJO32teWYoV40GNOmuhPX/VSOeM6oyXBkK9rxcEUAdnaFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hiUknVoB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hiUknVoB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E861F000E9; Tue, 21 Jul 2026 17:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784656463; bh=c0ZtDBdftEK49dFotET/bP4o5FTH6SNy+KZ9J7fojQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hiUknVoBSOgfElKWJAz69K1fIT9t8V4p0XrRFZNjLBkpReOe0OlsW1OC7zyHFMaL/ X++5rFmQqWw4QCpGiaEawNuiAHJajm0wBNwFmqTjNHV+ee0PdLtsPDgMiScq1SOcdN sdpwhAeWM+MjFLzuxV0Kt60YFaEbYK46L9lhvjKQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wolfram Sang , Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.18 0397/1611] hwspinlock: qcom: avoid uninitialized struct members Date: Tue, 21 Jul 2026 17:08:33 +0200 Message-ID: <20260721152524.158634024@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang [ Upstream commit 8752c396ce3b2136b3d4c906fe103f6efb6782d9 ] The reg_field is allocated on stack, so using the REG_FIELD macro will ensure that unused members do not have uninitialized values. Fixes: 19a0f61224d2 ("hwspinlock: qcom: Add support for Qualcomm HW Mutex block") Link: https://sashiko.dev/#/patchset/20260319105947.6237-1-wsa%2Brenesas%40sang-engineering.com Signed-off-by: Wolfram Sang Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20260512091339.31085-2-wsa+renesas@sang-engineering.com Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/hwspinlock/qcom_hwspinlock.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index 0390979fd765d0..712003a4640cc1 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -202,7 +202,6 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev, static int qcom_hwspinlock_probe(struct platform_device *pdev) { struct hwspinlock_device *bank; - struct reg_field field; struct regmap *regmap; size_t array_size; u32 stride; @@ -224,9 +223,7 @@ static int qcom_hwspinlock_probe(struct platform_device *pdev) platform_set_drvdata(pdev, bank); for (i = 0; i < QCOM_MUTEX_NUM_LOCKS; i++) { - field.reg = base + i * stride; - field.lsb = 0; - field.msb = 31; + struct reg_field field = REG_FIELD(base + i * stride, 0, 31); bank->lock[i].priv = devm_regmap_field_alloc(&pdev->dev, regmap, field); -- 2.53.0