From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89E83B4EAC; Tue, 21 Jul 2026 18:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784657607; cv=none; b=iHBJWZlrX9FbJeBJO+bPUHSJ16AVgHE5eQsk1XK1Y06MsBzoJtT2/JzP/TUpSstO4YInnqKGzdhPswMCL3s1JzXXapZ/a+8wZgmTLRCpewTc9fzaNsIqowIqDFMFvV50o/Sd/heASMF50tmBHNbVmNxEkt4RSLCGV9ze1HkcUmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784657607; c=relaxed/simple; bh=X+aBeDyMJHtI5DtYJFtx3GaSTfQjZHoKOEcjtQcA9Hw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qdZL/P+RNh9MaLMrktOzUXHAXARzVVVGs3FQhOBdULHzSwVkN6chSI9ImgpPh+wZNbJEVzSiaP0VpLByDCQfeKK4tViitae7pIWsXH954p2vMad48UC7qoGPPFNiGUNW/lvWsQBvKkWEZQiPGPPR5QRBAjhCo2Ss+SO6WUfxD+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Fw4xAOvB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Fw4xAOvB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 601D61F000E9; Tue, 21 Jul 2026 18:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784657605; bh=n5xSY+wCVeV94NigxGpyOQyHHgZ7givPfc3tcqntTCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Fw4xAOvBVF2MYdkapldX2yKWOIiolaIsOsGqluDplPzVV65Mr37xY5B3D84QEeG47 XtVtBBeqBfy2xzYlQqKweE7zqxI5oPbgL+5I5vsFybJRHlC8kXlPyCiVfN1T80FAto Xmp+79L+yhzU1A/Ri9h77P69AkEdG9S5XG+LEyeI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+e0bd4e4815a910c0daa8@syzkaller.appspotmail.com, Kuniyuki Iwashima , Miquel Raynal , Ivan Abramov , Stefan Schmidt , Sasha Levin Subject: [PATCH 6.18 0827/1611] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns() Date: Tue, 21 Jul 2026 17:15:43 +0200 Message-ID: <20260721152533.989924509@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Abramov [ Upstream commit 0569f67ed6a7af838e2141da93c68e6b6013f483 ] It's pointless to call WARN_ON() in case of an allocation failure in dev_change_net_namespace() and device_rename(), since it only leads to useless splats caused by deliberate fault injections, so avoid it. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: 66e5c2672cd1 ("ieee802154: add netns support") Reported-by: syzbot+e0bd4e4815a910c0daa8@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/000000000000f4a1b7061f9421de@google.com/#t Reviewed-by: Kuniyuki Iwashima Reviewed-by: Miquel Raynal Signed-off-by: Ivan Abramov Link: https://lore.kernel.org/20250403101935.991385-3-i.abramov@mt-integration.ru Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/ieee802154/core.c b/net/ieee802154/core.c index 84d514430e45a5..987c633e2c549f 100644 --- a/net/ieee802154/core.c +++ b/net/ieee802154/core.c @@ -228,8 +228,10 @@ int cfg802154_switch_netns(struct cfg802154_registered_device *rdev, continue; wpan_dev->netdev->netns_immutable = false; err = dev_change_net_namespace(wpan_dev->netdev, net, "wpan%d"); - if (err) + if (err) { + WARN_ON(err && err != -ENOMEM); break; + } wpan_dev->netdev->netns_immutable = true; } @@ -237,7 +239,7 @@ int cfg802154_switch_netns(struct cfg802154_registered_device *rdev, goto errout; err = device_rename(&rdev->wpan_phy.dev, dev_name(&rdev->wpan_phy.dev)); - WARN_ON(err); + WARN_ON(err && err != -ENOMEM); if (err) goto errout; @@ -258,7 +260,7 @@ int cfg802154_switch_netns(struct cfg802154_registered_device *rdev, wpan_dev->netdev->netns_immutable = false; err = dev_change_net_namespace(wpan_dev->netdev, net, "wpan%d"); - WARN_ON(err); + WARN_ON(err && err != -ENOMEM); wpan_dev->netdev->netns_immutable = true; } -- 2.53.0