From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD2346C4DE; Tue, 21 Jul 2026 18:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784657880; cv=none; b=WfV2wo0/yKfXttq1JJArIIwO9O9BfIZKBMmU/vPaTqQwPczaQqAYp7GdYG52YGxNH57wdHVGz/xXsaaGDKKs/C+TcbB4you1aW44S5OWg2sWzEnxVp6+yTG7Z5Lhn6V8/QOdQIaiF7w0DR88CKnFX607oUiCn2rAemPz0QcBb7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784657880; c=relaxed/simple; bh=+o0U/AqaxLDZaP4BlcJyz8hkmSgLf9x+3bpp83uDR10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cu/qJmWDWy2RnRjWICD3uJx3JblJGQa6ZP3SMpgAPopF1I4UklvQnjlNdyK1XQVStVyfl3U61Wkdnej2vOZNhBt/k83J1Sf6x2NTme3IlBF6+Tq2nNZ6K/IEt9Jz/Qo1Xuamc5263Y3qRYBT5HTooWX9Rlk9Rxrnr2QNhNdmmag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yUZ6Fcc1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yUZ6Fcc1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69F4F1F00A3A; Tue, 21 Jul 2026 18:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784657875; bh=0oVbgCU1tv2UaHd4dMgCfPRlMhDzg+0+P7C7sa5JTPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yUZ6Fcc1EjVSe4kps2B2SfHTRYx5X9GmTQgtgj24RJGxPqPN1sCTdJBNemAnjuytI glw4vJr4SuUyr+8ihBw6uvY6TZ+1pC1TLx9IfWshyI7xt3f51XMmQXIzJIUNeQh6MH ljXzNpco/Vk8gHNAbpL16A5E7XM5b1mk6oQcXYlg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marcin Szycik , Aleksandr Loktionov , Paul Menzel , Patryk Holda , Tony Nguyen , Sasha Levin Subject: [PATCH 6.18 0887/1611] ice: call netif_keep_dst() once when entering switchdev mode Date: Tue, 21 Jul 2026 17:16:43 +0200 Message-ID: <20260721152535.342201560@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152514.750365251@linuxfoundation.org> References: <20260721152514.750365251@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marcin Szycik [ Upstream commit c0d00c882bc432990d57052a659f9a8bd1f60687 ] netif_keep_dst() only needs to be called once for the uplink VSI, not once for each port representor. Move it from ice_eswitch_setup_repr() to ice_eswitch_enable_switchdev(). Fixes: defd52455aee ("ice: do Tx through PF netdev in slow-path") Signed-off-by: Marcin Szycik Signed-off-by: Aleksandr Loktionov Reviewed-by: Paul Menzel Tested-by: Patryk Holda Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_eswitch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c index 2e4f0969035f77..c30e27bbfe6e25 100644 --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c @@ -117,8 +117,6 @@ static int ice_eswitch_setup_repr(struct ice_pf *pf, struct ice_repr *repr) if (!repr->dst) return -ENOMEM; - netif_keep_dst(uplink_vsi->netdev); - dst = repr->dst; dst->u.port_info.port_id = vsi->vsi_num; dst->u.port_info.lower_dev = uplink_vsi->netdev; @@ -312,6 +310,8 @@ static int ice_eswitch_enable_switchdev(struct ice_pf *pf) if (ice_eswitch_br_offloads_init(pf)) goto err_br_offloads; + netif_keep_dst(uplink_vsi->netdev); + pf->eswitch.is_running = true; return 0; -- 2.53.0