From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14E2746AA83; Tue, 21 Jul 2026 15:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784649288; cv=none; b=EJRWse9E4uXL5oev8HyouoWDeklYL4O4DoAOCLaA3aN/tfv6ANJAKc7opjuaV85sGf9Ikm4wvLYLKwJZnODqrGefVgRU1nzy8EQ319tVr1uFLoaYDOMg9YIwwZODQSeHVmpDOWDyFka8JL6zS3hQDzByAynQFZJGGHU3RBezpPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784649288; c=relaxed/simple; bh=niMpmHBw8Yedsiaa1gpBf5gbc2MV2K4PXUzRoccn9QY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GSObmR35pIvNWNUGxce7YVxwjVbEu7DdMkMF3uaUD8IiwCBgjDDJoPN8ysbEJyLPTixUFS5b5M8B+9xzLisZ9MvbsucuMN9ecEEjczm7nbHwteUK1pXQB5QPxJHOcK8W1v2crIkZzGPc1vSIFjfbxu5Of+h4bWTbgzmhxlUydqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IvrmYZNw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IvrmYZNw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 794081F000E9; Tue, 21 Jul 2026 15:54:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784649287; bh=Cv/rAwEbDBIA7UsXwFchgG+ySjbx2kpUo2qN1wyGPG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IvrmYZNwQSbT3QnuZ9lOeClb2gclbh+tYBk16rtjxdaRYZ2CoqyoWcBNHVvPGiZu9 fjWFvOEGjQhSBu/rR3KO78fNQbFfTOhwu1w9lkDUQxpFy3iQO82qD7OslTVDEv6PRZ SWSt1Dwcu7ZBJOO8ClEQ0gxVGnloylNuaK3XCRFs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tristan Madani , Loic Poulain , Jeff Johnson , Sasha Levin Subject: [PATCH 7.1 0521/2077] wifi: wcn36xx: fix OOB read from firmware count in PRINT_REG_INFO indication Date: Tue, 21 Jul 2026 17:03:14 +0200 Message-ID: <20260721152605.099076102@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tristan Madani [ Upstream commit df2187acfca6c6cca372c5d35f42394d9c270b09 ] The firmware-controlled rsp->count field is used as the loop bound for indexing into the flexible rsp->regs[] array without validation against the message length. A count exceeding the actual data causes out-of- bounds reads from the heap-allocated message buffer. Add a check that count fits within the received message. Fixes: 43efa3c0f241 ("wcn36xx: Implement print_reg indication") Signed-off-by: Tristan Madani Reviewed-by: Loic Poulain Link: https://patch.msgid.link/20260421135018.352774-3-tristmd@gmail.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/wcn36xx/smd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index f65328329f4f08..2a0c946d810950 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c @@ -2805,6 +2805,12 @@ static int wcn36xx_smd_print_reg_info_ind(struct wcn36xx *wcn, return -EIO; } + if (rsp->count > (len - sizeof(*rsp)) / sizeof(rsp->regs[0])) { + wcn36xx_warn("Truncated print reg info indication: count %u, len %zu\n", + rsp->count, len); + return -EIO; + } + wcn36xx_dbg(WCN36XX_DBG_HAL, "reginfo indication, scenario: 0x%x reason: 0x%x\n", rsp->scenario, rsp->reason); -- 2.53.0