From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C69446C4BC; Tue, 21 Jul 2026 18:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660246; cv=none; b=VkTlkRq4Gwq8C/1lG1ymXsLnz8Dig9MxTsZQPWEICkT8HcES9FdM+64AihJ9rKWgOFbOAV3egz+Z41bSAoNY4vXXpx9A5faFZVH3Ty4dvca5/9s09FUoUyttkaot6AKzN9zi/n343yLtYB7dIuUhw3f/F7/oMPK968JhhSgrNcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660246; c=relaxed/simple; bh=9g/BLZiSR6oZKNyebGnM2Ula4Sgz9hwh+RPGGAx9gWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=liwMpzNv1vLxDgsLHPMz2sIR7N84+FYKOvbiHfmufoPe4qZeS1dYcyRkIDrIPLOimvE12cXg+Pl5UvLEUsI4MGYcnpgYzKgQjgqeXLY1DXNhLFwtCIx1SChdxxXNwoVN6gmaY9XkAx6Hdbdr+w1FRiIkqePMvwTYAU6NxzvRDWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xGwJ47vx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xGwJ47vx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A29881F000E9; Tue, 21 Jul 2026 18:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784660245; bh=hhTirOhm6PMaSmYPADucZtrxrDC6f7jd5OrWgHGOu9M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xGwJ47vxKxtb7VUlbWWrtj289T1xxmsjo1ZL+ehKVQ94ESEhB1AFuSbGk2dUfr8eY IIZmMVxvrqPmpVA5KUQscGKAnvXaQWRcFlnviqnuQvjlyuE+EQkF50oeuB2zsH5vkd AuJw2yQF5UePXO5FJ8Q31ONYt/ocRkZfHyr1YEq8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , Joshua Crofts , Jonathan Cameron , Sasha Levin Subject: [PATCH 7.1 0906/2077] iio: light: si1133: reset counter to prevent race condition Date: Tue, 21 Jul 2026 17:09:39 +0200 Message-ID: <20260721152614.189154218@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joshua Crofts [ Upstream commit 0a5f45ed2342aabae1e32c72558d15be28940a95 ] Sashiko reported a potential race condition happening when the driver returns an errno after a timeout in the si1133_command() function. The premature exit causes the hardware and software counters to become out of sync by not updating data->rsp_seq, therefore the internal hardware counter keeps incrementing. Fix this by adding a call to si1133_cmd_reset_counter() before returning from timeout. Fixes: e01e7eaf37d8 ("iio: light: introduce si1133") Reported-by: sashiko-bot Closes: https://sashiko.dev/#/message/20260428-si1133-checkup-v2-5-70ad14bfefe2%40gmail.com Assisted-by: gemini:gemini-3.1-pro-preview Signed-off-by: Joshua Crofts Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/light/si1133.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 44fa152dbd24c2..c88c79202be2e2 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -427,6 +427,11 @@ static int si1133_command(struct si1133_data *data, u8 cmd) dev_warn(dev, "Failed to read command 0x%02x, ret=%d\n", cmd, err); + /* + * Reset counter on err to prevent software and hardware + * counters being out of sync. + */ + si1133_cmd_reset_counter(data); goto out; } } -- 2.53.0