Re: [PATCH v3 3/4] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit modifies a regex pattern despite the commit message explicitly claiming no patterns were changed.
--

--- Patch [3]: [PATCH v3 3/4] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks ---
commit 5d9830a03b3532641c37f4db55bf3e194063f0c9
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: arm: qcom-soc: Validate nodes with fallbacks

The schema checking for expected naming patterns for SoC IP block nodes
was incomplete and was checking only nodes with single compatible. This
commit changes select to contains so that nodes having at least one matching
compatible will be evaluated.

>     These two above are the only functional changes in this commit and the
>     rest of the diff is indentation change.  None of the patterns are
>     changed (neither in "Preferred naming style" group nor in "Legacy
>     namings"), none of the compatibles are affected.

[Severity: Medium]
The commit message states that none of the patterns are changed, but the
diff below shows the regex pattern for the codenames variant was modified to
end with "-.+$" instead of "-.*$".

Is this pattern change intended despite the commit message?

> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index dbc7877ee30e2..e72502f8df2c7 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
[ ... ]
>  properties:
>    compatible:
> -    oneOf:
> -      # Preferred naming style for compatibles of SoC components:
> -      - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
> -      - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
> -      - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
> -      - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.*$"
> +    contains:
> +      anyOf:
> +        # Preferred naming style for compatibles of SoC components:
> +        - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
> +        - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
> +        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
> +        - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.+$"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-dt-bindings-qcom-soc-naming-v3-0-8f275c9d3412@oss.qualcomm.com?part=3