From: Tianyuan Jiang <code_0002@163.com>
To: krzk@kernel.org
Cc: konrad.dybcio@oss.qualcomm.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Tianyuan Jiang <code_0002@163.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: sm8550: add xiaomi pad 6s pro (sheng) dts
Date: Wed, 22 Jul 2026 00:00:09 +0800 [thread overview]
Message-ID: <20260721160009.535-1-code_0002@163.com> (raw)
In-Reply-To: <20260721142147.1618-1-code_0002@163.com>
Hi Krzysztof,
I sincerely apologise for the rapid version spam (v2-v6 in one hour).
That was completely wrong and I understand your frustration. It happened
because of a misconfiguration in my automated workflow -- I was trying
to fix issues iteratively but each fix triggered a new send without
proper review. This will not happen again.
Here is the checkpatch.pl --strict output on the latest DTS (v6 fixes
applied):
total: 0 errors, 81 warnings, 0 checks, 1769 lines checked
The 81 warnings are all "DT compatible string appears un-documented".
Most are false positives because I'm on Windows without grep, so
checkpatch cannot search the bindings directory. Compatibles like
qcom,sm8550, regulator-fixed, gpio-keys, usb-c-connector etc. are
properly documented in the tree. In a normal Linux environment with grep
available, I expect the count to drop significantly.
Changes since v2 (based on review feedback from Konrad and others):
- Removed all output-low/output-high from TLMM pinctrl (Konrad)
- Reordered root-level nodes alphabetically (Konrad)
- pinctrl-n placed before pinctrl-names file-wide (Konrad)
- cs35l43 reset: GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN (Konrad)
- firmware-name paths: qcom/sm8550/xiaomi-sheng/ (Konrad)
- ktz8866a: add kinetic,ktz8866 fallback compatible
- assigned-clocks added to mdss_dsi1
- Removed msm-id, board-id, Xiaomi-specific comments
- Removed udmabuf bootargs (confirmed not in use)
- Fixed node sorting, alignment, and comment style
- Fixed From/Signed-off-by to use real name: Tianyuan Jiang
- Line length fixed (mbhc-buttons-vthreshold-microvolt)
Regarding the undocumented DT compatibles (fpc,fpc1020, gt9764, ps5169,
novatek,nt36532e, etc.), I am preparing separate bindings patches for
each and plan to submit them as a series. Would it be acceptable to you
to land the DTS first with these as follow-up patches, or do you prefer
all bindings to be merged before the DTS?
I will send one clean v7 once we align on the approach. No more version
spam. Thank you for your patience.
Regards,
Tianyuan Jiang
prev parent reply other threads:[~2026-07-21 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 14:21 [PATCH v2] arm64: dts: qcom: sm8550: add Xiaomi Pad 6S Pro (sheng) code_0002
2026-07-21 14:41 ` Konrad Dybcio
2026-07-21 14:41 ` Konrad Dybcio
2026-07-21 14:49 ` sashiko-bot
2026-07-21 15:22 ` Krzysztof Kozlowski
2026-07-21 15:34 ` [PATCH v6] " Tianyuan Jiang
2026-07-21 15:46 ` Krzysztof Kozlowski
2026-07-21 15:52 ` sashiko-bot
2026-07-21 16:00 ` Tianyuan Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721160009.535-1-code_0002@163.com \
--to=code_0002@163.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.