Re: [RFC PATCH bpf-next 1/3] selftests/bpf: extract BPF skeleton generation into a helper script

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly extracted `gen_bpf_skel.sh` script is not listed as a prerequisite for the skeleton header targets.
--

--- Patch [1]: [RFC PATCH bpf-next 1/3] selftests/bpf: extract BPF skeleton generation into a helper script ---
commit 4513e1c5bea1eb3326128c6ae08f7e1f230247fb
Author: Mykola Lysenko <nickolay.lysenko@gmail.com>

selftests/bpf: extract BPF skeleton generation into a helper script

This commit extracts the duplicate skeleton generation pipeline from the
Makefile into a standalone shell script. This simplifies the rules by
replacing them with calls to gen_bpf_skel.sh using different flags.

> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index b642ee489ea64..e3a27403cd481 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
[ ... ]
> @@ -631,81 +631,38 @@ $(TRUNNER_BPF_OBJS): $(TRUNNER_OUTPUT)/%.bpf.o:				\
>  					  $$($$<-$2-CFLAGS),$(TRUNNER_BINARY))
>  
>  $(TRUNNER_BPF_SKELS): %.skel.h: %.bpf.o $(BPFTOOL) | $(TRUNNER_OUTPUT)
[ ... ]
> +	$(Q)BPFTOOL=$$(BPFTOOL) ./gen_bpf_skel.sh --tag '$(TRUNNER_BINARY)'	\

[Severity: Low]
Should gen_bpf_skel.sh be added as a prerequisite for $(TRUNNER_BPF_SKELS)
and the other skeleton targets?

Without the script in the dependencies list, modifying the script itself
won't trigger a rebuild of the existing .skel.h and .lskel.h files.
This could lead to stale builds during development if the script's logic
is updated.

> +		--name $$(notdir $$(<:.bpf.o=)) --infix linked			\
> +		--skel $$@ --subskel $$(@:.skel.h=.subskel.h) $$< $(if $(PERMISSIVE),|| { \
> +		$$(RM) $$@ $$(@:.skel.h=.subskel.h);				\
> +		printf '  %-12s %s\n' 'SKIP-SKEL' '$$(notdir $$@)' 1>&2; })
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721174909.8044-1-nickolay.lysenko@gmail.com?part=1