Re: [PATCH 1/2] ASoC: qcom: remove ipq806x Storm machine driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Removing SND_SOC_STORM leaves SND_SOC_LPASS_IPQ806X without any selectors, rendering the IPQ806X LPASS CPU driver completely unbuildable and unreachable.
- [Low] The device tree binding documentation for the removed google,storm-audio driver was left behind.
--

--- Patch [1]: [PATCH 1/2] ASoC: qcom: remove ipq806x Storm machine driver ---
commit 76b009b0b947fd2197dab876d7f10fb5105c7935
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

ASoC: qcom: remove ipq806x Storm machine driver

The Storm board machine driver targets Google's IPQ806x-based Storm
reference board. This driver is removed together with its Kconfig
entry and Makefile rule since it has no upstream device tree and no
active users.

> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index e6e24f3b99222..68e3146bf2307 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -47,15 +47,6 @@ config SND_SOC_LPASS_SC7280
>  	select SND_SOC_LPASS_HDMI
>  	select SND_SOC_LPASS_CDC_DMA
>  
> -config SND_SOC_STORM
> -	tristate "ASoC I2S support for Storm boards"
> -	depends on GPIOLIB
> -	select SND_SOC_LPASS_IPQ806X

[Severity: Medium]
Does removing SND_SOC_STORM leave SND_SOC_LPASS_IPQ806X without any selectors?

SND_SOC_LPASS_IPQ806X lacks a prompt in Kconfig, so without any selectors it
cannot be enabled manually or by COMPILE_TEST. This leaves the IPQ806X LPASS
CPU driver (sound/soc/qcom/lpass-ipq806x.c) and its Makefile entry as
unbuildable dead code.

Should SND_SOC_LPASS_IPQ806X and lpass-ipq806x.c be cleaned up in this patch as
well?

[ ... ]

> diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
> deleted file mode 100644
> index 1e0eda8c24c4e..0000000000000
> --- a/sound/soc/qcom/storm.c
> +++ /dev/null

[ ... ]

> -#ifdef CONFIG_OF
> -static const struct of_device_id storm_device_id[]  = {
> -	{ .compatible = "google,storm-audio" },
> -	{},
> -};

[Severity: Low]
Does the device tree binding documentation for "google,storm-audio" still exist
in the tree?

Removing this compatible string might leave behind obsolete binding
documentation, such as Documentation/devicetree/bindings/sound/storm.txt.
Should the corresponding binding file be removed alongside the driver?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-drop-sound-storm-v1-0-23ae4a689ffe@oss.qualcomm.com?part=1