All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Saverio Miroddi" <saverio.pub2@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/DOE: Add debug messages for transaction failures
Date: Tue, 21 Jul 2026 19:35:51 +0000	[thread overview]
Message-ID: <20260721193552.1F8E21F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260721193310.1179300-1-saverio.pub2@gmail.com>

> DOE feature discovery reports only -EIO when several distinct mailbox
> status and response-validation failures occur. The abort used to recover
> the mailbox can then clear the status before it is captured, leaving the
> existing failed-to-cache-features message insufficient to identify the
> failing phase.
> 
> Add dynamic-debug messages immediately before the silent error returns.
> Log the transaction phase and raw status or response length, but do not
> change mailbox behavior or expose payload contents.
> 
> On a WD_BLACK SN8100 NVMe device (15b7:5050, firmware 830ZRR0A), whose
> mailbox creation fails on every boot, these messages identified the
> failure: the device accepts the Discovery request but never presents a
> response, and the transaction times out with the Busy bit still set:
> 
>   pci 0000:05:00.0: DOE: [500] response timeout, status: 0x00000001
>   pci 0000:05:00.0: DOE: [500] failed to cache features : -5
>   pci 0000:05:00.0: DOE: [500] failed to create mailbox: -5
> 
> Signed-off-by: Saverio Miroddi <saverio.pub2@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721193310.1179300-1-saverio.pub2@gmail.com?part=1


  reply	other threads:[~2026-07-21 19:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 19:33 [PATCH] PCI/DOE: Add debug messages for transaction failures Saverio Miroddi
2026-07-21 19:35 ` sashiko-bot [this message]
2026-11-03 23:29 ` Mitar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721193552.1F8E21F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=saverio.pub2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.