From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
linux-kernel@vger.kernel.org,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Arnd Bergmann" <arnd@arndb.de>, "Nick Huang" <sef1548@gmail.com>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts: headers_install.sh: Normalize __ASSEMBLY__ to __ASSEMBLER__
Date: Tue, 21 Jul 2026 13:54:55 -0700 [thread overview]
Message-ID: <20260721205455.GA91346@ax162> (raw)
In-Reply-To: <178463249517.1439086.5460375188993284761.b4-review@b4>
On Tue, Jul 21, 2026 at 01:14:55PM +0200, Nicolas Schier wrote:
> > A previous patch to headers_install.sh normalized the usage of
> > __ASSEMBLER__ to __ASSEMBLY__ in the UAPI headers due to the
> > assumption that older versions of GCC might not define __ASSEMBLER__
> > automatically and thus using __ASSEMBLER__ in the UAPI headers might
> > break compilation with very old versions of GCC. However, as we now
> > reassured, even GCC 2.95 still defines __ASSEMBLER__ automatically
> > (and even older versions are hopefully not in use with the current
> > Linux UAPI headers anymore).
> > __ASSEMBLER__ is also set automatically by other C compilers like PCC
> > (see https://github.com/IanHarvey/pcc/blob/cvs2git/2018.09.20/cc/cc/cc.1#L405)
> > and Tiny-C (see https://repo.or.cz/tinycc.git/commitdiff/a25325e9be13e52a),
> > so using __ASSEMBLER__ in UAPI header files should really be fine.
> >
> > Thus let's head forwards and standardize on __ASSEMBLER__ instead
> > of __ASSEMBLY__ in the UAPI header files now.
> >
> > Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
> > Link: https://lore.kernel.org/all/2030a963-33bc-43fe-9a2b-9c626d7d8360@redhat.com/
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> >
> > diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> > index 83e447596878..2f1d1767ca26 100755
> > --- a/scripts/headers_install.sh
> > +++ b/scripts/headers_install.sh
> > @@ -36,7 +36,7 @@ sed -E -e '
> > s/(^|[^a-zA-Z0-9])__packed([^a-zA-Z0-9_]|$)/\1__attribute__((packed))\2/g
> > s/(^|[[:space:](])(inline|asm|volatile)([[:space:](]|$)/\1__\2__\3/g
> > s@#(ifndef|define|endif[[:space:]]*/[*])[[:space:]]*_UAPI@#\1 @
> > - s/__ASSEMBLER__/__ASSEMBLY__/g
> > + s/__ASSEMBLY__/__ASSEMBLER__/g
> > ' $INFILE > $TMPFILE || exit 1
> >
> > scripts/unifdef -U__KERNEL__ -D__EXPORTED_HEADERS__ $TMPFILE > $OUTFILE
>
> Thanks!
>
> Reviewed-by: Nicolas Schier <n.schier@fritz.com>
> Tested-by: Nicolas Schier <n.schier@fritz.com>
>
> Even though squashing both commits sounds good to me on the first hand,
> I don't want to do that right now, to simplify a possible revert in case
> of reported regressions.
Given the additional information provided in this commit message, I
think it is fine to keep them separate, even aside from the regressions
concern.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-07-21 20:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 10:10 [PATCH] scripts: headers_install.sh: Normalize __ASSEMBLY__ to __ASSEMBLER__ Thomas Huth
2026-07-21 11:14 ` Nicolas Schier
2026-07-21 20:54 ` Nathan Chancellor [this message]
2026-07-21 21:32 ` Thomas Weißschuh
2026-07-22 7:34 ` Thomas Huth
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 15:58 Thomas Weißschuh
2026-03-13 23:56 ` Nathan Chancellor
2026-03-24 17:05 ` Thomas Weißschuh
2026-03-24 18:35 ` Nathan Chancellor
2026-03-24 19:58 ` Thomas Weißschuh
2026-06-13 10:13 ` Nicolas Schier
2026-06-13 16:57 ` Nathan Chancellor
2026-07-16 10:24 ` Thomas Huth
2026-07-16 16:40 ` Thomas Weißschuh
2026-07-16 18:16 ` Maciej W. Rozycki
2026-07-17 15:25 ` Thomas Weißschuh
2026-07-20 15:31 ` Maciej W. Rozycki
2026-07-16 18:52 ` Thomas Huth
2026-07-17 15:28 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721205455.GA91346@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=nsc@kernel.org \
--cc=sef1548@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.