All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saverio Miroddi <saverio.pub2@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: bus: Avoid misleading _OSC missing-feature errors
Date: Wed, 22 Jul 2026 02:06:32 +0200	[thread overview]
Message-ID: <20260722000632.2285535-1-saverio.pub2@gmail.com> (raw)
In-Reply-To: <20260722001452.019b3e32@jic23-huawei>

Hi!

Yes, that's my understanding, with one qualification: we can only infer this from the returned buffer.

The returned capability mask acknowledges every capability requested by OSPM, while OSC_CAPABILITIES_MASK_ERROR says that at least one requested bit was cleared. Since the requested and returned masks are identical, those two parts of the response are inconsistent. The protocol-visible result acknowledges all requested capabilities, so the status bit appears to be a firmware bug.

I'll clarify this in the comment.

For the logging, I'll keep "_OSC: errors while processing control request" for every error return and condition only "_OSC: some features may be missing". That preserves the firmware error report without claiming that capabilities were removed.

Best,
Saverio

  reply	other threads:[~2026-07-22  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 19:29 [PATCH] ACPI: bus: Avoid misleading _OSC missing-feature errors Saverio Miroddi
2026-07-21 23:14 ` Jonathan Cameron
2026-07-22  0:06   ` Saverio Miroddi [this message]
2026-07-22 13:03 ` [PATCH v1] ACPI: bus: Avoid confusing complaints regarding missing _OSC features Rafael J. Wysocki
2026-07-22 15:34   ` Saverio Miroddi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722000632.2285535-1-saverio.pub2@gmail.com \
    --to=saverio.pub2@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.