From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 5.15.y 2/5] i2c: core: fix reference leak in i2c_register_adapter()
Date: Tue, 21 Jul 2026 20:50:43 -0400 [thread overview]
Message-ID: <20260722005046.603973-2-sashal@kernel.org> (raw)
In-Reply-To: <20260722005046.603973-1-sashal@kernel.org>
From: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
[ Upstream commit 3f8c4f5e9a57868fa107016c81165686d23325f2 ]
The reference count of the device incremented in device_initialize() is
not decremented when device_add() fails. Add a put_device() call before
returning from the function.
This bug was found by an experimental static analysis tool that I am
developing.
Fixes: 60f68597024d ("i2c: core: Setup i2c_adapter runtime-pm before calling device_add()")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Stable-dep-of: 158efa411c57 ("i2c: core: fix adapter probe deferral loop")
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/i2c/i2c-core-base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 1df75dcea8b97f..4b3960fa35f7bb 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -1564,6 +1564,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
res = device_add(&adap->dev);
if (res) {
pr_err("adapter '%s': can't register device (%d)\n", adap->name, res);
+ put_device(&adap->dev);
goto out_list;
}
--
2.53.0
next prev parent reply other threads:[~2026-07-22 0:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 12:40 FAILED: patch "[PATCH] i2c: core: fix adapter probe deferral loop" failed to apply to 5.15-stable tree gregkh
2026-07-22 0:50 ` [PATCH 5.15.y 1/5] i2c: core: Setup i2c_adapter runtime-pm before calling device_add() Sasha Levin
2026-07-22 0:50 ` Sasha Levin [this message]
2026-07-22 0:50 ` [PATCH 5.15.y 3/5] i2c: core: fix irq domain leak on adapter registration failure Sasha Levin
2026-07-22 0:50 ` [PATCH 5.15.y 4/5] i2c: core: fix NULL-deref " Sasha Levin
2026-07-22 0:50 ` [PATCH 5.15.y 5/5] i2c: core: fix adapter probe deferral loop Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722005046.603973-2-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=stable@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.