From: Jonathan Cameron <jic23@kernel.org>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <iweiny@kernel.org>, Dan Williams <djbw@kernel.org>,
Li Ming <ming.li@zohomail.com>,
linux-cxl@vger.kernel.org,
Srirangan Madhavan <smadhavan@nvidia.com>
Subject: Re: [PATCH v4 4/4] cxl/hdm: Restore commit_end when decoder enumeration fails
Date: Wed, 22 Jul 2026 02:17:12 +0100 [thread overview]
Message-ID: <20260722021712.0107f7fc@jic23-huawei> (raw)
In-Reply-To: <3b2d66e380cb00b1365911a59f32739580d82563.1784595445.git.alison.schofield@intel.com>
On Mon, 20 Jul 2026 18:59:40 -0700
Alison Schofield <alison.schofield@intel.com> wrote:
> commit_end tracks the highest committed decoder on a port. It gets
> advanced before decoder enumeration is complete, so a later failure
> leaves it pointing at a decoder that was never added. The next probe
> then rejects decoder0 as out of order and enumeration fails.
>
> Reset commit_end to the none committed baseline once the decoders are
> torn down, so a subsequent probe rebuilds it from scratch. Register
> the reset before the decoders are added so that on unwind it runs
> after every decoder has been unregistered. This prevents commit_end
> from dropping below the highest committed decoder still registered and
> exposing an inconsistent value to a concurrent reader.
>
> Protect the commit_end advance in the DVSEC emulation path against
> concurrent readers, matching the register-programmed path.
>
> Fixes: 176baefb2eb5 ("cxl/hdm: Commit decoder state to hardware")
> Fixes: b777e9bec960 ("cxl/hdm: Emulate HDM decoder from DVSEC range registers")
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
next prev parent reply other threads:[~2026-07-22 1:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 1:59 [PATCH v4 0/4] Harden HDM decoder enumeration Alison Schofield
2026-07-21 1:59 ` [PATCH v4 1/4] cxl/hdm: Reject switch decoder interleave ways that overflow targets Alison Schofield
2026-07-21 2:14 ` sashiko-bot
2026-07-21 6:27 ` Li Ming
2026-07-22 0:55 ` Jonathan Cameron
2026-07-21 1:59 ` [PATCH v4 2/4] cxl/hdm: Only interpret interleave settings on committed decoders Alison Schofield
2026-07-21 6:26 ` Li Ming
2026-07-21 1:59 ` [PATCH v4 3/4] cxl/hdm: Make switch decoder target parsing endian-safe Alison Schofield
2026-07-21 15:09 ` Dave Jiang
2026-07-22 1:07 ` Jonathan Cameron
2026-07-21 1:59 ` [PATCH v4 4/4] cxl/hdm: Restore commit_end when decoder enumeration fails Alison Schofield
2026-07-21 6:28 ` Li Ming
2026-07-21 15:12 ` Dave Jiang
2026-07-22 1:17 ` Jonathan Cameron [this message]
2026-07-21 9:41 ` [PATCH v4 0/4] Harden HDM decoder enumeration Richard Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722021712.0107f7fc@jic23-huawei \
--to=jic23@kernel.org \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=djbw@kernel.org \
--cc=iweiny@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=smadhavan@nvidia.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.