Re: [PATCH for-next v10 4/6] RDMA/core: Add Completion Counters to resource tracking

[Leon Romanovsky <leon@kernel.org>]

On Tue, Jul 21, 2026 at 05:14:53PM +0000, Michael Margolin wrote:
> On Tue, Jul 21, 2026 at 05:16:59PM +0300, Leon Romanovsky wrote:
> > On Mon, Jul 20, 2026 at 01:22:19PM +0000, Michael Margolin wrote:
> > > Track completion counter objects in the resource tracking database so
> > > they are visible through the rdma netlink interface. The rdma tool
> > > displays the comp_cntr count in the resource summary.
> > > 
> > > Add RDMA_RESTRACK_COMP_CNTR type, embed rdma_restrack_entry in
> > > ib_comp_cntr, and add the res_to_dev mapping. Register the resource
> > > on create and remove it on destroy.
> > > 
> > > Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> > > Signed-off-by: Michael Margolin <mrgolin@amazon.com>
> > > ---
> > >  drivers/infiniband/core/nldev.c                      | 8 ++++++++
> > >  drivers/infiniband/core/restrack.c                   | 2 ++
> > >  drivers/infiniband/core/uverbs_std_types_comp_cntr.c | 6 ++++++
> > >  include/rdma/ib_verbs.h                              | 1 +
> > >  include/rdma/restrack.h                              | 4 ++++
> > >  5 files changed, 21 insertions(+)
> > 
> > <...>
> > 
> > > @@ -48,7 +50,11 @@ static int UVERBS_HANDLER(UVERBS_METHOD_COMP_CNTR_CREATE)(struct uverbs_attr_bun
> > >  	if (ret)
> > >  		goto err_free;
> > >  
> > > +	rdma_restrack_new(&cc->res, RDMA_RESTRACK_COMP_CNTR);
> > 
> > This is an unexpected location. I would expect restrack
> > initialization to occur before ops.create_comp_cntr.
> > 
> > Thanks
> 
> No problem, I'll move it.

Rest looks ok.

Thanks

> 
> Michael
> 
> > 
> > > +	rdma_restrack_set_name(&cc->res, NULL);
> > > +
> > >  	uobj->object = cc;
> > > +	rdma_restrack_add(&cc->res);
> > >  	uverbs_finalize_uobj_create(attrs, UVERBS_ATTR_CREATE_COMP_CNTR_HANDLE);
> > >  	return 0;