From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2203A380FF1 for ; Wed, 22 Jul 2026 07:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784704047; cv=none; b=QXSxUNaFtXSZwR6qtIdVD9ZfPMUoEtAWq3AVPMNdymBLI+TqyZK3E1p5Fe6N9HkLhaJKLvdTsmdoXgrB+Gr0tgPJl/lhrtSXdGpmlkNmEBn1qlNmdAGwYtdCySa39LH/qf9NuR34TMsYGlFG6SLwmd+wIyr1PiTO9bcp82fYzDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784704047; c=relaxed/simple; bh=re/speWcOGwko6/FivO1AH7qay8ysB1ntlnYj2wNFUY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SaVMFOeuR0/TYRa5yzj928QFfvcpJ8oil/7OVlokGyRtsEHqalVWIkYnuIMn7QWsoFhh6LYc4NZfdmgWcjVlCHetl7DPZoR4M7/5cY/2reGUaVwUdJ3e64Sjf3RSYjfkYBbZSSeybPAA1TxJ7rUbTaYKvVvMrMhqHIzAC9r5H0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nDUFEQfT; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nDUFEQfT" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so8164872f8f.1 for ; Wed, 22 Jul 2026 00:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784704044; x=1785308844; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6PxNNHc80S4oYsV0n6VwB4u3z9k7dWvx3UfOOSVFbyM=; b=nDUFEQfTFkk1n+fMkTDqFpGEX5ARYCkjK5p/+qsUR3seHL64CXTmrE3ofShuUpvafD 7A+IpO33oIWqDVYsNiXUOBFVwFE/4icw21pvKKU5CyP3gtkhPdIn0ykzZ2BPl/3uZYi9 ErEZzOgV3MisQ8jqCHSK10+lj3kuN0gIj4e3T5IE/u8zG/h7HE3/83WCY6xYXG0OQlix OGgbOhaDtaCzpwWZHJIxMmNhvWQ/vTq2SxErWPTblxw2ddcyjYwkWKLpYLFABdBn7n1m rlBIHTA7OaR9uPAAfuhEbyhFHPApO5nV7cF+R75PUH041qWaOU3v9ITodqsbuc3Y7bYO SZKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784704044; x=1785308844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6PxNNHc80S4oYsV0n6VwB4u3z9k7dWvx3UfOOSVFbyM=; b=fyfCOcHxOFU3Ciuh3iTDB6rON/9UiRYDi9EGfywTLf3XBnzG4H6pt5jgpj0sJX3KGT J8P/fFotbcZVxPwAqvSsWqEcDYYdSvb/KwCXD81Vkan7dMRlarkcmMo1twWdtOWnwhOK 9eDD1w72eBEHnIgj6OjFMkLLikBf/VSNQ7JLdGUzML4VANzzxXJR/K70elSjgAKkEren DTwVmXRybBVY4Ffi9MciOVEOrBPVBcsgvibyK2PvfLGh6v2SdMZ1U60jNsiG/JBETolT eyEBrpClqsl/t/9tLEWZZY2xNHBrmXEtTf59xJfFcpKeYDyoC1FC/xhY0iHu+879OUhR +sag== X-Forwarded-Encrypted: i=1; AHgh+RobzGGvszFOswaphDkgpjZewhmCQq94OTiSAD36UyhDlwnWxN76K+Hm71SC9xm45qiFvHddDHNhyBLXiWE=@vger.kernel.org X-Gm-Message-State: AOJu0YwiT12yPFpywSCXmvXmiZaTwBfvjAl3S3GVrDMLR6oXBuKu3nw/ bSW3I0q+lPSZ+1o2jVm29Lah82JTekZUIHrZcD/FVk2EBqJvot2iw7Wq X-Gm-Gg: AR+sD107LORl+Q2MCF6Wyq/fXhsyWwoQdoTBxQGfkniOox/ig2Ej4DddNJ4XFuSyVpP e2EUYHyN4vLHGyJE51O3ps5kymMxp3RoAnnZxWw1l4QWR2FGl5QKvXwgTaZV91pi0Q5SVYDfJ5r Okr4fpuQHjCKOxU+CEZBxIhQTFspfBNHoBLrPNI3YSyjO74441NEYXiZ0NSAklRYUEcL5aMwDMj RkhlqtAcvD6eV0dIqgYt1DhJUprs5DcZQmHFl33wsb0CUIvHwSs4uigx0DPiUFd1BXIUveXb2OD mv9hvOrNFQTpIwTUhwyWJJl07TnoF/HJNqOsSCmv1zeSkNTI3Anu6tuwD2/XWWbt+SrUmY4ltZj VzmUgKG4bfl5ifJX1xJP4JUujT8XbFSbnFzb9dsYD1bGno84jW8Edpoig+3y11j8OQSUOnVCMPV 5qeMCAh4n6jbEPMeYqzDqtaFy1l64XAuyCr5de X-Received: by 2002:adf:e004:0:10b0:47d:fc20:f6f9 with SMTP id ffacd0b85a97d-47f62320eabmr17459538f8f.45.1784704043822; Wed, 22 Jul 2026 00:07:23 -0700 (PDT) Received: from localhost ([102.128.173.0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a64dsm3363403f8f.1.2026.07.22.00.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 00:07:23 -0700 (PDT) From: Louis Kotze To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, loukot@gmail.com Subject: Re: [PATCH v2 1/2] wifi: cfg80211: say why the auth/assoc BSS lookup failed Date: Wed, 22 Jul 2026 09:07:20 +0200 Message-ID: <20260722070720.3610942-1-loukot@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 2026-07-22 at 00:10 +0200, Johannes Berg wrote: > > + if (!attrs[NL80211_ATTR_MAC] || !attrs[NL80211_ATTR_WIPHY_FREQ]) { > > + NL_SET_ERR_MSG(info->extack, "BSSID or frequency missing"); > > could use the GENL versions and save some characters :) Done in v3. > > - NL_SET_ERR_MSG_ATTR(info->extack, link, > > - "Error fetching BSS for link"); > > + NL_SET_BAD_ATTR(info->extack, link); > > why remove the message, it's possible to have both? There still is a message here: __cfg80211_get_bss() has already set the specific one by the time this runs, and NL_SET_ERR_MSG_ATTR() would overwrite it with the generic text again. Added a comment in v3 to make that visible. > > - req.bss = nl80211_assoc_bss(rdev, ssid, ssid_len, info->attrs, > > - -1, -1); > > + req.bss = nl80211_assoc_bss(rdev, info, ssid, ssid_len, > > + info->attrs, -1, -1); > > entirely unrelated (whitespace) change? The call gains the new "info" argument; v3 keeps the original wrapping so only that shows in the diff. > That code should probably have a comment that the is_bss() must come > first... Added. > Also however, it could result in having *both* 'unusable' and > 'expired' set, and then > [...] > you prefer the 'unusable' message... not sure that makes sense? Right. v3 sets a combined message when matching entries were rejected for different reasons, so neither is preferred or hidden. > I also don't think the "scan again" instruction makes any sense here - > this is meant to provide an error message, not instructions how to fix > it? Dropped, the messages are purely descriptive now. Sending v3 shortly. thanks, Louis