Re: [RFC PATCH 3/3] arm64: dts: rockchip: rk3576: add VEPU H.264 encoder nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree nodes are not sorted by unit-address in ascending order.
--

--- Patch [3]: [RFC PATCH 3/3] arm64: dts: rockchip: rk3576: add VEPU H.264 encoder nodes ---
commit 6e5cf8fb6138851fdbc5bc797d5562505948a1ae
Author: Jiaxing Hu <gahing@gahingwoo.com>

arm64: dts: rockchip: rk3576: add VEPU H.264 encoder nodes

This commit adds the two VEPU510 encoder cores at 0x27a00000 and 0x27a10000
along with their corresponding IOMMUs to the rk3576 device tree.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index e12a2a0cfb891..58d706d563290 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1314,6 +1314,56 @@ vdec_mmu: iommu@27b00800 {
>  			#iommu-cells = <0>;
>  		};
>  
> +		vepu0: video-codec@27a00000 {

[Severity: Low]
This isn't a bug, but should these new nodes be placed before vdec_mmu?

The device tree coding style generally expects nodes to be sorted by their
unit-address in ascending order. Here, the vepu0 node at 0x27a00000 and
subsequent vepu1 node at 0x27a10000 are being placed after vdec_mmu at
0x27b00800.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722073417.2064667-1-gahing@gahingwoo.com?part=3