Re: [PATCH v7 6/7] dt-bindings: iio: dac: Add AD5529R

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The child node schema uses `additionalProperties: false` alongside a `$ref`, which incorrectly blocks valid properties from the referenced schema.
--

--- Patch [6]: [PATCH v7 6/7] dt-bindings: iio: dac: Add AD5529R ---
commit 7d0649d467110abde25b98986887b22fbe5ea358
Author: Janani Sunil <janani.sunil@analog.com>
Subject: dt-bindings: iio: dac: Add AD5529R

This commit introduces device tree bindings for the Analog Devices AD5529R, a
16-channel, 12-bit or 16-bit high voltage DAC. The bindings specify power
supplies, SPI interface parameters, GPIOs for reset and clear, and individual
channel configurations.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
[ ... ]
> +patternProperties:
> +  "^channel@([0-9a-f]{1,2})$":
> +    $ref: dac.yaml
> +    type: object
> +    description: Child nodes for individual channel configuration
[ ... ]
> +    required:
> +      - reg
> +
> +    additionalProperties: false

[Severity: Low]
Will using additionalProperties: false here block properties evaluated by the
$ref to dac.yaml? 

Standard DAC properties like label might fail validation during dtbs_check
when added to channel nodes. 

Should this be changed to unevaluatedProperties: false instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-ad5529r-driver-v7-0-7781cd74ad75@analog.com?part=6