From: sashiko-bot@kernel.org
To: "Richard Leitner" <richard.leitner@linux.dev>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] dt-bindings: regmap: add common schema for no-sequential-read
Date: Wed, 22 Jul 2026 08:49:17 +0000 [thread overview]
Message-ID: <20260722084917.7CDCE1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260722-regmap-single-read-v1-1-aaaf31591669@linux.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `maintainers` field in the newly introduced DT binding schema contains the placeholder 'TBD'. The device tree schema validation (`dtschema`) mandates that all items in the `maintainers` property must be valid names and email addresses matching the format 'Name <email@example.com>'. This will cause `make dt_binding_check` to fail.
--
--- Patch [1]: [PATCH RFC 1/2] dt-bindings: regmap: add common schema for no-sequential-read ---
commit 309f545ffe78e2e1263494a044512db6b6e61394
Author: Richard Leitner <richard.leitner@linux.dev>
dt-bindings: regmap: add common schema for no-sequential-read
This commit introduces a common regmap dt-binding schema with an optional
boolean property no-sequential-read. This describes hardware integrations
where reading multiple consecutive registers in a single operation is not
reliable and registers must be read individually.
> diff --git a/Documentation/devicetree/bindings/regmap/common.yaml b/Documentation/devicetree/bindings/regmap/common.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regmap/common.yaml
> @@ -0,0 +1,26 @@
[ ... ]
> +title: Common register access constraints
> +
> +maintainers:
> + - TBD
[Severity: Low]
Will this cause make dt_binding_check to fail?
Device tree schema validation mandates that all items in the maintainers
property must be valid names and email addresses matching the format
Name <email@example.com>. The placeholder TBD does not match this format
and will trigger a meta-schema validation error.
> +
> +description:
> + Common properties describing register access constraints.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-regmap-single-read-v1-0-aaaf31591669@linux.dev?part=1
next prev parent reply other threads:[~2026-07-22 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 8:42 [PATCH RFC 0/2] regmap: support firmware-described non-sequential register reads Richard Leitner
2026-07-22 8:42 ` [PATCH RFC 1/2] dt-bindings: regmap: add common schema for no-sequential-read Richard Leitner
2026-07-22 8:49 ` sashiko-bot [this message]
2026-07-22 13:59 ` Mark Brown
2026-07-22 8:42 ` [PATCH RFC 2/2] regmap: implement no-sequential-read firmware property Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722084917.7CDCE1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=richard.leitner@linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.