Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Moving `qcom,eliza-adsp-pas` to an items list requiring a fallback breaks backward compatibility and schema validation for the existing in-tree device tree.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema ---
commit de0588624107f153559b1ce48e9d1f56b81467d0
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema

The ADSP PAS found on Eliza SoC looks fully compatible with SM8750, which
can fallback to SM8550 except for the extra interrupt ("shutdown-ack").
So document its bindings in the SM8550 schema instead.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 2a4c527552e69..e6d81a38fd1c0 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -29,6 +29,7 @@ properties:
>            - qcom,x1e80100-cdsp-pas
>        - items:
>            - enum:
> +              - qcom,eliza-adsp-pas

[Severity: Medium]
Will this break dtbs_check for existing device trees?

Looking at arch/arm64/boot/dts/qcom/eliza.dtsi, the compatible string is
currently defined without the newly required fallback:

arch/arm64/boot/dts/qcom/eliza.dtsi:
		remoteproc_adsp: remoteproc@3000000 {
			compatible = "qcom,eliza-adsp-pas";

Since this schema change now strictly requires the items array to include
the qcom,sm8550-adsp-pas fallback string, does this break backward
compatibility and cause schema validation to fail for the existing in-tree
device tree?

>                - qcom,glymur-adsp-pas
>                - qcom,hawi-adsp-pas
>                - qcom,kaanapali-adsp-pas

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-dts-qcom-eliza-fix-adsp-binding-v2-0-e1e98ae15533@oss.qualcomm.com?part=1