Re: [PATCH v6 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree binding intentionally omits the HDMI input port, violating the fundamental rule that Device Tree describes the physical hardware independent of driver implementation.
--

--- Patch [1]: [PATCH v6 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding ---
commit e9e6db2f5d5e1b4ac21c4df62354e0ec71117d3a
Author: Hermes Wu <Hermes.wu@ite.com.tw>

dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding

This commit documents the devicetree binding for the ITE IT6625/IT6626 HDMI
to MIPI CSI-2 bridge. It exposes two selectable CSI-2 output graph ports,
port@0 and port@1.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
> new file mode 100644
> index 0000000000000..fed732e4428ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
[ ... ]
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: CSI-2 output port MIPI0

[Severity: Medium]
The commit message mentions dropping the HDMI input graph port because the
driver does not use it. Does omitting this input port conflict with the
principle that devicetree schemas should describe the physical hardware
independent of driver implementation?

Because the physical hardware acts as an HDMI bridge, device tree authors
would need a documented port index under properties.ports to accurately link
an upstream HDMI source to the bridge.

Without an explicitly defined input port, will this prevent boards from
accurately describing their video graph topology, potentially leading to
inconsistent or missing routing connections across different devices?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-upstream-it6625-it6626-v6-0-6117d4d96574@ite.com.tw?part=1