From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C377C44536 for ; Wed, 22 Jul 2026 19:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k3cKZHNKkxiMPr147PoKWBfyqUlokFrq1vkTgSjLR2M=; b=37E9WVQ93vuG/KEpBLteEdDcnt whPtpwwLiNgDlZHReMCcygMy+hWOpC0CxGsHpDcBCeeEl1zTSM4e/x1hyGSsr1lwVRNTD1Zd0Bikx iUhU6lRfTQ0KzoKaAdc9PZXC8TOukAAXIsmaFEPaittcUO8mybmUh8Ka7NdY6lM56rUOeHzXEliI5 thh8NOtbN6HA8sw3YZ7TxRn9sZeYurjzlnmzT0+y7oXzr1aj8XVePdAsqfCZLhfOTtJ9gxghppT2j HtbwUc/448t9HDdsPMJBGDV488PAKudAeV8bSEBmrazBcOXSfEEs5apuG7w06QXxXnTwatFp/27Dq Rh4PluFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmciM-0000000CeKi-3Dtp; Wed, 22 Jul 2026 19:34:46 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmciL-0000000CeK8-0baw; Wed, 22 Jul 2026 19:34:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id AF0C6600AB; Wed, 22 Jul 2026 19:34:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 095871F000E9; Wed, 22 Jul 2026 19:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784748883; bh=k3cKZHNKkxiMPr147PoKWBfyqUlokFrq1vkTgSjLR2M=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=BCdLAaRbUhLJZE0yjvfo44pq6kTbR5XON2H4wcewN+EtmS+2Tjm2tRLuWee60Wddh HvbKJpKRdqnu7TY7jk4hAphw9smS28PAjm9/jBkfaSTg9Is2vO+M3bvvls+ErCMd+u NVYaNhQQ1ovkQo0XTlw9JfDzTwZW54Lg82E10CvL5KCWmxAqMD/xw0LEeu7O0kQ+CV BdrwAsPxqf331Jio+jdWyqGkGWe4yqe7QcoZM3CuoNkqVYTHe4G5IYAOqBiS5DPysW wrZUsc0f3BpyeKqEhPaD2x7ozsF82Ew1pmIRf7e8lY9LkWEWIlJD72fQ4HYnhX7+vZ gqiaIzQ+oEDmg== Date: Wed, 22 Jul 2026 12:34:42 -0700 From: Jakub Kicinski To: Chenguang Zhao Cc: nbd@nbd.name, lorenzo@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Chenguang Zhao Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: pass eth to mtk_handle_irq_rx in poll_controller Message-ID: <20260722123442.0434e14a@kernel.org> In-Reply-To: <20260717022339.301914-1-chenguang.zhao@linux.dev> References: <20260717022339.301914-1-chenguang.zhao@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Jul 2026 10:23:39 +0800 Chenguang Zhao wrote: > From: Chenguang Zhao > > mtk_handle_irq_rx expects a struct mtk_eth * (matching the request_irq > cookie), but mtk_poll_controller incorrectly passed the net_device *. > Calling ndo_poll_controller with CONFIG_NET_POLL_CONTROLLER enabled > would then crash. missing sign-off and fixes tags