From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
Paulo Alcantara <pc@manguebit.org>, Jens Axboe <axboe@kernel.dk>,
Leon Romanovsky <leon@kernel.org>,
Steve French <sfrench@samba.org>,
ChenXiaoSong <chenxiaosong@chenxiaosong.com>,
Marc Dionne <marc.dionne@auristor.com>,
Stefan Metzmacher <metze@samba.org>,
Eric Van Hensbergen <ericvh@kernel.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Ilya Dryomov <idryomov@gmail.com>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH v7 05/29] afs: Fix afs_edit_dir_remove() to get, not find, block 0
Date: Wed, 22 Jul 2026 14:01:52 +0100 [thread overview]
Message-ID: <20260722130218.78958-6-dhowells@redhat.com> (raw)
In-Reply-To: <20260722130218.78958-1-dhowells@redhat.com>
Fix afs_edit_dir_remove() to use afs_dir_get_block() to get block 0 rather
than afs_dir_find_block() as the latter caches the found block in the
afs_dir_iter and may[*] switch out the page it's on if another
afs_dir_find_block() is done. This parallels what afs_edit_dir_add() does.
[*] There's more than one block per page.
Fixes: a5b5beebcf96 ("afs: Use the contained hashtable to search a directory")
Closes: https://sashiko.dev/#/patchset/20260706153408.1231650-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
cc: stable@vger.kernel.org
---
fs/afs/dir_edit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/afs/dir_edit.c b/fs/afs/dir_edit.c
index fd3aa9f97ce6..3ead36a07048 100644
--- a/fs/afs/dir_edit.c
+++ b/fs/afs/dir_edit.c
@@ -415,7 +415,7 @@ void afs_edit_dir_remove(struct afs_vnode *vnode,
if (!afs_dir_init_iter(&iter, name))
return;
- meta = afs_dir_find_block(&iter, 0);
+ meta = afs_dir_get_block(&iter, 0);
if (!meta)
return;
next prev parent reply other threads:[~2026-07-22 13:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 13:01 [PATCH v7 00/29] netfs: Keep track of folios in a segmented bio_vec[] chain David Howells
2026-07-22 13:01 ` [PATCH v7 01/29] netfs: clear PG_private_2 on copy-to-cache append failure David Howells
2026-07-22 13:01 ` [PATCH v7 02/29] netfs: handle single writeback rolling buffer allocation failure David Howells
2026-07-22 13:01 ` [PATCH v7 03/29] netfs: release readahead folios on iterator preparation failure David Howells
2026-07-22 13:01 ` [PATCH v7 04/29] afs: Fix missing kunmap in afs_dir_search_bucket() David Howells
2026-07-22 13:01 ` David Howells [this message]
2026-07-22 13:01 ` [PATCH v7 06/29] afs: Fix double-unmap of directory block David Howells
2026-07-22 13:01 ` [PATCH v7 07/29] mm: Make readahead store folio count in readahead_control David Howells
2026-07-22 13:01 ` [PATCH v7 08/29] netfs: Bulk load the readahead-provided folios up front David Howells
2026-07-22 13:01 ` [PATCH v7 09/29] Add a function to kmap one page of a multipage bio_vec David Howells
2026-07-22 13:01 ` [PATCH v7 10/29] iov_iter: Make iov_iter_get_pages*() wrap iov_iter_extract_pages() David Howells
2026-07-22 13:01 ` [PATCH v7 11/29] iov_iter: Add a segmented queue of bio_vec[] David Howells
2026-07-22 13:01 ` [PATCH v7 12/29] netfs: Add some tools for managing bvecq chains David Howells
2026-07-22 13:02 ` [PATCH v7 13/29] netfs: Add a function to extract from an iter into a bvecq David Howells
2026-07-22 13:02 ` [PATCH v7 14/29] afs: Use a bvecq to hold dir content rather than folioq David Howells
2026-07-22 13:02 ` [PATCH v7 15/29] cifs: Use a bvecq for buffering instead of a folioq David Howells
2026-07-22 13:02 ` [PATCH v7 16/29] smbdirect: Support ITER_BVECQ in smbdirect_map_sges_from_iter() David Howells
2026-07-22 13:02 ` [PATCH v7 17/29] netfs: Remove the writethrough code David Howells
2026-07-22 13:02 ` [PATCH v7 18/29] cachefiles,netfs: sunset ondemand mode David Howells
2026-07-22 13:02 ` [PATCH v7 19/29] cachefiles: Don't rely on backing fs storage map for most use cases David Howells
2026-07-22 13:02 ` [PATCH v7 20/29] netfs: Add the cache object ID to netfs_read/write tracepoints David Howells
2026-07-22 13:02 ` [PATCH v7 21/29] netfs: Switch to using bvecq rather than folio_queue and rolling_buffer David Howells
2026-07-22 13:02 ` [PATCH v7 22/29] smbdirect: Remove support for ITER_FOLIOQ from smbdirect_map_sges_from_iter() David Howells
2026-07-22 13:02 ` [PATCH v7 23/29] netfs: Remove netfs_alloc/free_folioq_buffer() David Howells
2026-07-22 13:02 ` [PATCH v7 24/29] netfs: Remove netfs_extract_user_iter() David Howells
2026-07-22 13:02 ` [PATCH v7 25/29] iov_iter: Remove ITER_FOLIOQ David Howells
2026-07-22 13:02 ` [PATCH v7 26/29] netfs: Remove folio_queue and rolling_buffer David Howells
2026-07-22 13:02 ` [PATCH v7 27/29] netfs: Check for too much data being read David Howells
2026-07-22 13:02 ` [PATCH v7 28/29] netfs: Limit the minimum trigger for progress reporting David Howells
2026-07-22 13:02 ` [PATCH v7 29/29] netfs: Combine prepare and issue ops and grab the buffers on request David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722130218.78958-6-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chenxiaosong@chenxiaosong.com \
--cc=christian@brauner.io \
--cc=ericvh@kernel.org \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=leon@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=metze@samba.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.