From: sashiko-bot@kernel.org
To: "Harald Freudenberger" <freude@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v5 1/1] s390/pkey: Rework ioctl functions error paths
Date: Wed, 22 Jul 2026 14:37:18 +0000 [thread overview]
Message-ID: <20260722143718.DDC8C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260722142947.109588-2-freude@linux.ibm.com>
> With the pkey rework there was the suggestion to rework the error and
> free paths of the pkey ioctl functions. The complain was especially to
> rewrite the failure handling with goto instead of all repeat the
> nearly same code (kfree(), kfree_sensitive(), memzero_explicit()) for
> each path. This patch removes all this duplicated code and introduces
> one code block at the end of the functions which is jumped into via
> goto out or executed on regular exit. As some helper functions return
> an error pointer value (which is NOT NULL) make sure on the error path
> there is not by accident kfree() or similar called on such ptr values.
>
> Suggested-by: Heiko Carstens <hca@linux.ibm.com>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260722142947.109588-2-freude@linux.ibm.com?part=1
prev parent reply other threads:[~2026-07-22 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 14:29 [PATCH v5 0/1] Rework pkey ioctl functions error paths Harald Freudenberger
2026-07-22 14:29 ` [PATCH v5 1/1] s390/pkey: Rework " Harald Freudenberger
2026-07-22 14:37 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722143718.DDC8C1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.