Re: [PATCH V19 3/9] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The regmap_read_poll_timeout macro will abort immediately if the I2C read fails during reset, rendering the 10ms timeout ineffective.
--

--- Patch [3]: [PATCH V19 3/9] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver ---
commit 126a2bd0ca185e39e3153f40088acc8d7f3a3ac0
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add inv_icm42607 Core Driver

This commit adds the core component and I2C driver for the InvenSense
ICM-42607 motion tracking device. It provides the setup functions, register
definitions, and basic probing infrastructure.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> new file mode 100644
> index 0000000000000..6ec1d730017e2
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c

[ ... ]

> +static int inv_icm42607_setup(struct inv_icm42607_state *st,
> +			      inv_icm42607_bus_setup inv_icm42607_bus_setup)
> +{

[ ... ]

> +	ret = regmap_write(st->map, INV_ICM42607_REG_SIGNAL_PATH_RESET,
> +			   INV_ICM42607_SIGNAL_PATH_RESET_SOFT_RESET);
> +	if (ret)
> +		return ret;
> +
> +	fsleep(1 * USEC_PER_MSEC);
> +
> +	/*
> +	 * No polling interval specified in datasheet, so use reset time as
> +	 * polling interval and 10x reset time as timeout period.
> +	 */
> +	ret = regmap_read_poll_timeout(st->map, INV_ICM42607_REG_INT_STATUS,
> +				       val, val & INV_ICM42607_INT_STATUS_RESET_DONE,
> +				       1 * USEC_PER_MSEC, 10 * USEC_PER_MSEC);

[Severity: Medium]
Can this timeout be bypassed entirely if the I2C bus NACKs right after a
soft reset?

Since regmap_read_poll_timeout() terminates its polling loop immediately
if the underlying read returns an error, a single NACK during the reset
window will cause the macro to return an error (like -ENXIO) right away.

If the hardware requires slightly more than 1ms to stabilize, would this
cause the probe to fail instantly instead of utilizing the 10ms polling
window to retry?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722153942.144387-1-macroalpha82@gmail.com?part=3