Re: [PATCH RFC v2 15/20] mm/pgtable: optimize pmdp_get() and friends for folded pagetable levels

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect parameter name in the newly defined pgdp_get() function.
--

--- Patch [15]: [PATCH RFC v2 15/20] mm/pgtable: optimize pmdp_get() and friends for folded pagetable levels ---
commit 2c4b6d6a43469a09eb2dcdd35ef29b1bda716b3a
Author: David Hildenbrand (Arm) <david@kernel.org>

mm/pgtable: optimize pmdp_get() and friends for folded pagetable levels

This commit optimizes pmdp_get() and related functions for configurations
with folded page tables. It avoids unnecessary memory reads by returning a
dummy value instead of forcing the compiler to read unused data.

Link: https://lore.kernel.org/all/0019d675-ce3d-4a5c-89ed-f126c45145c9@kernel.org/

> diff --git a/include/asm-generic/pgtable-nop4d.h b/include/asm-generic/pgtable-nop4d.h
> index 019c3f074b771..ab4a826b34048 100644
> --- a/include/asm-generic/pgtable-nop4d.h
> +++ b/include/asm-generic/pgtable-nop4d.h
> @@ -34,6 +34,14 @@ static inline bool pgd_leaf(pgd_t pgd)		{ return false; }
>   */
>  #define set_pgd(pgdptr, pgdval)	set_p4d((p4d_t *)(pgdptr), (p4d_t) { pgdval })
>  
> +static inline pgd_t pgdp_get(pgd_t *p4dp)

[Severity: Low]
This isn't a bug, but should the parameter for pgdp_get() here be named pgdp
instead of p4dp?

> +{
> +	pgd_t dummy = { 0 };
> +
> +	return dummy;
> +}
> +#define pgdp_get pgdp_get

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722-dummy_ptxp3-v2-0-d9e4bad31e0a@arm.com?part=15