From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B23439F88 for ; Wed, 22 Jul 2026 16:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784737739; cv=none; b=HikH0khT3nJOuVHqQekGJpvh1IocOMpLRy2lkXPJCxhIou8KkmyR2k6TBPSL4IY3TWn+CvRbQ9+hBuReR6cR50L4GAZGL0ouW55hop7MVaaTHTZO5C2W6TT6e+oK8S+D3uk/wzfa2qXi4jsUWzXraxtZxwq9YfkNR4RBbuUS/uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784737739; c=relaxed/simple; bh=r613kEmjpbBze0gbN9Six+06zQmJjNLzVxD7jXwVnbE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SKXQZ4pnGkYo8G6kkixbJwj04vm77lMsJPiR8tRwPZRsZk+swmhdLmJMRcC3eQGLIZGewdk+XJrlHSfYLd+S/nunRzXS1ciwgaEuFGV8py2SgQcfG8TraAdKcR6NbVtTR2QCz6N8mRRGZVeCjUWA3q5CNSGUh1Ogq0DQeeZSiSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=epQAmjMa; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="epQAmjMa" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784737735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=AU/A+E28G3/lCyzXjRK9aFe90VdJO0cODy25bOQA+TE=; b=epQAmjMaWK6VpgCNIbPyX34/mgITmgbAZpr64kRhJU7TgbLtwywUA+8oR6YYf+ZrWhnz4x opF+KK1KVU8ywFg7Q8rseiEK1hxxJswU/1s3LzJhmsfopgyISGytxI+bnQOvr8Aaiow8rR UdTTzNHWWzovJemSpXlkSgYZUBA0zfU= From: Thorsten Blum To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" Cc: Thorsten Blum , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc/rtas_flash: Use scnprintf() in rtas_flash_read_num() Date: Wed, 22 Jul 2026 18:28:17 +0200 Message-ID: <20260722162816.156697-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1165; i=thorsten.blum@linux.dev; h=from:subject; bh=r613kEmjpbBze0gbN9Six+06zQmJjNLzVxD7jXwVnbE=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFkJ7xd8kX5rnWG7rOu7z7Vfz+5L/vrwSu16em7N+lSXV P3qTXJPOkpZGMS4GGTFFFkezPoxw7e0pnKTScROmDmsTCBDGLg4BWAiLnaMDItbfvzUbm87WLCO KeuzS+OLYF7Nw4tUOtqfLTl64+GWHkdGhq2BNYb7tmxnvxb71+z/ooMPXKXuJbktZ7SbfI43aem v21wA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Use scnprintf() and its return value to avoid a separate strlen() call. Signed-off-by: Thorsten Blum --- arch/powerpc/kernel/rtas_flash.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c index 583dc16e9d3c..aff8a67e274f 100644 --- a/arch/powerpc/kernel/rtas_flash.c +++ b/arch/powerpc/kernel/rtas_flash.c @@ -291,6 +291,7 @@ static ssize_t rtas_flash_read_num(struct file *file, char __user *buf, { struct rtas_update_flash_t *const uf = &rtas_update_flash_data; char msg[RTAS_MSG_MAXLEN]; + size_t len; int status; mutex_lock(&rtas_update_flash_mutex); @@ -298,8 +299,8 @@ static ssize_t rtas_flash_read_num(struct file *file, char __user *buf, mutex_unlock(&rtas_update_flash_mutex); /* Read as number */ - sprintf(msg, "%d\n", status); - return simple_read_from_buffer(buf, count, ppos, msg, strlen(msg)); + len = scnprintf(msg, sizeof(msg), "%d\n", status); + return simple_read_from_buffer(buf, count, ppos, msg, len); } /* We could be much more efficient here. But to keep this function