Re: [PATCH v3 3/3] drm/exynos: remove simplefb nodes before init

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between commit message intent and code ordering for removing conflicting framebuffers.
--

--- Patch [3]: [PATCH v3 3/3] drm/exynos: remove simplefb nodes before init ---
commit 7166a20a30c24daba54ef2dcd52625f999da3053
Author: Kaustabh Chakraborty <kauschluss@disroot.org>

drm/exynos: remove simplefb nodes before init

The simple-framebuffer uses the framebuffer region initialized by the
boot loader for display. However, with Linux the DSI and FIMD/DECON
stack is initialized from scratch.

> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 9ee30086879f9..7657f86a9d19d 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
[ ... ]
> @@ -273,6 +274,11 @@ static int exynos_drm_bind(struct device *dev)
>  	if (ret)
>  		goto err_mode_config_cleanup;
>  
> +	/* Remove existing devices which own the framebuffer memory. */
> +	ret = aperture_remove_all_conflicting_devices(exynos_drm_driver.name);

[Severity: Medium]
Does this code match the sequence described in the commit message?

The commit message explicitly states that "the framebuffer must be destroyed,
which releases the memory region, followed by proper IP re-initialization."

However, looking at exynos_drm_bind(), this call to
aperture_remove_all_conflicting_devices() happens right after
component_bind_all(). Since component callbacks like fimd_bind() reset the
hardware IPs, the IP re-initialization is actually happening before the
conflicting framebuffer device is removed.

Should the framebuffer removal happen before calling component_bind_all()
instead?

> +	if (ret)
> +		goto err_unbind_all;
> +
>  	ret = drm_vblank_init(drm, drm->mode_config.num_crtc);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-exynos-dsim-fixes-v3-0-0c31ae1dbecc@disroot.org?part=3