Re: [PATCH v2 2/4] dt-bindings: soc: imx-iomuxc-gpr: allow bridge@18 as child node

[Rob Herring <robh@kernel.org>]

On Sat, Jul 18, 2026 at 02:57:30PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Missing `ranges` property in `fsl,imx-iomuxc-gpr` schema will cause kernel WARN_ON at boot.
> --
> 
> --- Patch [2]: [PATCH v2 2/4] dt-bindings: soc: imx-iomuxc-gpr: allow bridge@18 as child node ---
> commit 5e999c2b583f7149956f10a90d92e24192451d5a
> Author: Frank Li <Frank.Li@nxp.com>
> 
> dt-bindings: soc: imx-iomuxc-gpr: allow bridge@18 as child node
> 
> The legacy i.MX6SX SoC imx-iomuxc-gpr contains one LDB_CTRL register.
> This patch updates the dt-bindings to allow the LVDS Display Bridge (LDB)
> child node under imx-iomuxc-gpr to resolve CHECK_DTBS warnings.
> 
> > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> > index 721a67e84c137..1879638918bab 100644
> > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx-iomuxc-gpr.yaml
> > @@ -47,10 +47,21 @@ properties:
> >    reg:
> >      maxItems: 1
> >  
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 1
> > +
> 
> [Severity: High]
> Will this omission of ranges cause a kernel WARN_ON at boot?
> 
> Because the syscon node includes the simple-mfd compatible, the kernel
> function of_platform_default_populate() will attempt to create platform
> devices for its children. For the bridge@18 child, of_device_alloc()
> attempts to parse its reg property.
> 
> Since the parent lacks a ranges property, of_translate_address() fails and
> returns OF_BAD_ADDR. This causes of_address_to_resource() to return
> -EINVAL, which is passed directly to a WARN_ON() in of_device_alloc().
> 
> Because additionalProperties is set to false in this schema, users are
> actively prevented from adding a valid ranges property to their device trees
> to fix this.
> 
> Should the ranges property be added to this schema and explicitly permitted
> so that device trees can provide the required address translation mapping?

You need ranges.

Rob