From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 032CEC4453C for ; Wed, 22 Jul 2026 21:54:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AECAF10E507; Wed, 22 Jul 2026 21:54:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="inb9xC+/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5F6A10E4F4 for ; Wed, 22 Jul 2026 21:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784757250; x=1816293250; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=7GcSI8M9h11oEg4QpcIenSam7BtGZcGRJMcQbLqyCsw=; b=inb9xC+/dq0RcSViPXoQxQCY5WoUBi7wRq1Ks5VGE1LVscuh09+l9PQx ajL1BfZAoqxHmEpeQtp6ne8uhnAWrHaIsOPZbkbMFCahiEDA8Gm1rHe0q 2vc/ymnUyLvBuuDVufzOwbE0zcxR1X0+EgZvU/PN9VW+yNIT6fIQhulJI k+s9khCmGPJijPLK8Hg27wUhISun8Ih31zvwGCaQpDk08nByyf/iNgdlY hj5fDStAU3W2dMjd8EMWTvH+lwx7++6QJbNdbe94qNrrk2mAYkLxsOHnD pYTulCRjhQl5eIZh0nf4EkvKmYyLbH6Nmk1iyB0e0ZHUf+8a+gfaxRisS Q==; X-CSE-ConnectionGUID: v9YQsKO4T4ieBlkLFtDjdg== X-CSE-MsgGUID: 2rQPf8ETSyalmznckUoxTw== X-IronPort-AV: E=McAfee;i="6800,10657,11854"; a="102950633" X-IronPort-AV: E=Sophos;i="6.25,179,1779174000"; d="scan'208";a="102950633" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2026 14:54:10 -0700 X-CSE-ConnectionGUID: AJZ2aXByRwCdLFRkIDg3Fw== X-CSE-MsgGUID: ZHA3e7QBSeiv4drutugIdg== X-ExtLoop1: 1 Received: from orsosgc001.jf.intel.com ([10.88.27.185]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2026 14:54:09 -0700 From: Umesh Nerlige Ramappa To: intel-xe@lists.freedesktop.org, Ashutosh Dixit Subject: [PATCH 2/3] drm/xe/xe_oa: Avoid checking and setting fields in the OA report Date: Wed, 22 Jul 2026 14:54:06 -0700 Message-ID: <20260722215403.2668958-7-umesh.nerlige.ramappa@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260722215403.2668958-5-umesh.nerlige.ramappa@intel.com> References: <20260722215403.2668958-5-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" OA unit updates the HW TAIL register to indicate that a new report is available, although it does not guarantee that the report is visible in memory. Also the currently running workload contributes to some latency in seeing this report in memory. In the past we would set some fields in the OA report and check if the fields are populated to non-zero values by the HW, but this is no longer sufficient since some parts of the report may land out of order under heavy workloads. Drop this WA and add a new logic in subsequent patches to return updated reports to the user. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/xe/xe_oa.c | 79 +------------------------------------- 1 file changed, 2 insertions(+), 77 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c index 5eb8f6739fae..c7f9c3955cb5 100644 --- a/drivers/gpu/drm/xe/xe_oa.c +++ b/drivers/gpu/drm/xe/xe_oa.c @@ -216,42 +216,6 @@ static u32 xe_oa_hw_tail_read(struct xe_oa_stream *stream) #define oa_report_header_64bit(__s) \ ((__s)->oa_buffer.format->header == HDR_64_BIT) -static u64 oa_report_id(struct xe_oa_stream *stream, u32 report_offset) -{ - struct iosys_map *map = &stream->oa_buffer.bo->vmap; - - return oa_report_header_64bit(stream) ? - xe_map_rd(stream->oa->xe, map, report_offset, u64) : - xe_map_rd(stream->oa->xe, map, report_offset, u32); -} - -static void oa_report_id_clear(struct xe_oa_stream *stream, u32 report_offset) -{ - struct iosys_map *map = &stream->oa_buffer.bo->vmap; - - oa_report_header_64bit(stream) ? - xe_map_wr(stream->oa->xe, map, report_offset, u64, 0) : - xe_map_wr(stream->oa->xe, map, report_offset, u32, 0); -} - -static u64 oa_timestamp(struct xe_oa_stream *stream, u32 report_offset) -{ - struct iosys_map *map = &stream->oa_buffer.bo->vmap; - - return oa_report_header_64bit(stream) ? - xe_map_rd(stream->oa->xe, map, report_offset + 8, u64) : - xe_map_rd(stream->oa->xe, map, report_offset + 4, u32); -} - -static void oa_timestamp_clear(struct xe_oa_stream *stream, u32 report_offset) -{ - struct iosys_map *map = &stream->oa_buffer.bo->vmap; - - oa_report_header_64bit(stream) ? - xe_map_wr(stream->oa->xe, map, report_offset + 8, u64, 0) : - xe_map_wr(stream->oa->xe, map, report_offset + 4, u32, 0); -} - static bool mert_wa_14026633728(struct xe_oa_stream *s) { return s->oa_unit->type == DRM_XE_OA_UNIT_TYPE_MERT && XE_DEVICE_WA(s->oa->xe, 14026633728); @@ -260,7 +224,7 @@ static bool mert_wa_14026633728(struct xe_oa_stream *s) static bool xe_oa_buffer_check_unlocked(struct xe_oa_stream *stream) { u32 gtt_offset = xe_bo_ggtt_addr(stream->oa_buffer.bo); - u32 tail, hw_tail, partial_report_size, available; + u32 hw_tail, partial_report_size, available; int report_size = stream->oa_buffer.format->size; unsigned long flags; @@ -280,29 +244,7 @@ static bool xe_oa_buffer_check_unlocked(struct xe_oa_stream *stream) /* Subtract partial amount off the tail */ hw_tail = xe_oa_circ_diff(stream, hw_tail, partial_report_size); - tail = hw_tail; - - /* - * Walk the stream backward until we find a report with report id and timestamp - * not 0. We can't tell whether a report has fully landed in memory before the - * report id and timestamp of the following report have landed. - * - * This is assuming that the writes of the OA unit land in memory in the order - * they were written. If not : (╯°□°）╯︵ ┻━┻ - */ - while (xe_oa_circ_diff(stream, tail, stream->oa_buffer.tail) >= report_size) { - if (oa_report_id(stream, tail) || oa_timestamp(stream, tail)) - break; - - tail = xe_oa_circ_diff(stream, tail, report_size); - } - - if (xe_oa_circ_diff(stream, hw_tail, tail) > report_size) - drm_dbg(&stream->oa->xe->drm, - "unlanded report(s) head=0x%x tail=0x%x hw_tail=0x%x\n", - stream->oa_buffer.head, tail, hw_tail); - - stream->oa_buffer.tail = tail; + stream->oa_buffer.tail = hw_tail; available = xe_oa_circ_diff(stream, stream->oa_buffer.tail, stream->oa_buffer.head); stream->pollin = available >= stream->wait_num_reports * report_size; @@ -387,23 +329,6 @@ static int xe_oa_append_reports(struct xe_oa_stream *stream, char __user *buf, ret = xe_oa_append_report(stream, buf, count, offset, head); if (ret) break; - - if (!(stream->oa_buffer.circ_size % report_size)) { - /* Clear out report id and timestamp to detect unlanded reports */ - oa_report_id_clear(stream, head); - oa_timestamp_clear(stream, head); - } else { - struct iosys_map *map = &stream->oa_buffer.bo->vmap; - u32 part = stream->oa_buffer.circ_size - head; - - /* Zero out the entire report */ - if (report_size <= part) { - xe_map_memset(stream->oa->xe, map, head, 0, report_size); - } else { - xe_map_memset(stream->oa->xe, map, head, 0, part); - xe_map_memset(stream->oa->xe, map, 0, 0, report_size - part); - } - } } if (start_offset != *offset) { -- 2.51.0