Re: [PATCH v10 02/11] x86: hw_breakpoint: Add a kconfig to clarify when a breakpoint fires

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Alphabetical sorting violation in arch/x86/Kconfig.
--

--- Patch [2]: [PATCH v10 02/11] x86: hw_breakpoint: Add a kconfig to clarify when a breakpoint fires ---
commit c9585173523a761e022d70aa1fafe72b621c85b9
Author: Masami Hiramatsu (Google) <mhiramat@kernel.org>

x86: hw_breakpoint: Add a kconfig to clarify when a breakpoint fires

Add CONFIG_HAVE_POST_BREAKPOINT_HOOK which indicates the hw_breakpoint
on that architecture fires after the target memory has been modified.
This is currently x86 only behavior.

> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index bdad90f210e4b..6b7e14ef8cfb3 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -246,6 +246,7 @@ config X86
>  	select HAVE_FUNCTION_TRACER
>  	select HAVE_GCC_PLUGINS
>  	select HAVE_HW_BREAKPOINT
> +	select HAVE_POST_BREAKPOINT_HOOK
>  	select HAVE_IOREMAP_PROT

[Severity: Low]
This isn't a bug, but should HAVE_POST_BREAKPOINT_HOOK be placed further
down in the list to maintain alphabetical sorting?

It is currently inserted before HAVE_IOREMAP_PROT.

>  	select HAVE_IRQ_EXIT_ON_IRQ_STACK	if X86_64
>  	select HAVE_IRQ_TIME_ACCOUNTING

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/178476134787.26117.10094977293012760490.stgit@devnote2?part=2