Re: [RFC PATCH 6/8] ASoC: SDCA: register SDCA_FUNCTION_TYPE_SIMPLE_JACK in class function driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing string mapping for SDCA_FUNCTION_TYPE_SIMPLE_JACK in get_sdca_function_name() causes ACPI enumeration failure.
--

--- Patch [6]: [RFC PATCH 6/8] ASoC: SDCA: register SDCA_FUNCTION_TYPE_SIMPLE_JACK in class function driver ---
commit 9826e21715fdea11e3c55eac5f9ed509d841b1d2
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

ASoC: SDCA: register SDCA_FUNCTION_TYPE_SIMPLE_JACK in class function driver

This commit adds SDCA_FUNCTION_TYPE_SIMPLE_JACK to the class function
driver's auxiliary ID table so a SimpleJack auxdev is bound and enumerated
as an ASoC component. It also wires up set_jack for this function type so
the machine driver can register an ASoC jack against it.

> diff --git a/sound/soc/sdca/sdca_class_function.c b/sound/soc/sdca/sdca_class_function.c
> --- a/sound/soc/sdca/sdca_class_function.c
> +++ b/sound/soc/sdca/sdca_class_function.c
[ ... ]
> @@ -621,6 +622,10 @@ static const struct auxiliary_device_id class_function_id_table[] = {
>  		.name = "snd_soc_sdca." SDCA_FUNCTION_TYPE_RJ_NAME,
>  		.driver_data = SDCA_FUNCTION_TYPE_RJ,
>  	},
> +	{
> +		.name = "snd_soc_sdca." SDCA_FUNCTION_TYPE_SIMPLE_NAME,
> +		.driver_data = SDCA_FUNCTION_TYPE_SIMPLE_JACK,
> +	},

[Severity: High]
Does this code also require a string mapping for
SDCA_FUNCTION_TYPE_SIMPLE_JACK in get_sdca_function_name()?

Looking at sound/soc/sdca/sdca_functions.c, the switch statement in
get_sdca_function_name() lacks a case for SDCA_FUNCTION_TYPE_SIMPLE_JACK,
causing it to return NULL.

When ACPI enumeration calls find_sdca_function() and encounters this
function type, the NULL return value causes it to fail:

sound/soc/sdca/sdca_functions.c:find_sdca_function() {
        ...
        function_name = get_sdca_function_name(function_type);
        if (!function_name) {
                dev_err(dev, "invalid SDCA function type %d\n", function_type);
                return -EINVAL;
        }
        ...
}

Because acpi_dev_for_each_child() stops iterating when a callback returns a
non-zero value, doesn't this error prevent the SimpleJack auxiliary device
from being registered and silently abort the enumeration of any subsequent
SDCA functions on the same device?

>  	{},
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722234221.884765-1-srinivas.kandagatla@oss.qualcomm.com?part=6