From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 310B4438FE7 for ; Thu, 23 Jul 2026 10:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784802090; cv=none; b=pbU6YoXGYAhtjh9sqNACfEzjs6vXInmrU665tbu25CTh6wzVw6NMofR/c/KzfUenKMlyPLiYyEdurr63YYi/2+3lYj2aErzChUMi4WICrlapD7z8zC7gcG4zbS7O0hXUM5yGYanP8uevSP9OjtWw85/d58lw/8Z40NqhzI/oSJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784802090; c=relaxed/simple; bh=dR2BsPw2pnsRHBOo/jlv8TkOF1+nIU4AoH874uso198=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=a9Uem+JBaI63vUb4MuJP73IP9itF7Q6yhdOXQRMJKlsuvpcXbYFf9E9KHUPwwHecG5hMJVh++Li4zD8jJNhtKH3hPv670J/gJl6aCXZi7Scne4J+lsuOlaxVjH75f6TGHcKs3lxhCCPJ/3X4yho8mdHDDm34DX22QbXtIPpqZ8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bsByqtiV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZtJoOIaB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bsByqtiV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZtJoOIaB" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N8qZEX3667999 for ; Thu, 23 Jul 2026 10:21:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=PSKeXsV8dg+pg/ChCFA5YK vPuaHbAUxkAi9j/OrnR/8=; b=bsByqtiVThLhd+hGYlOoLQUAiWmVcZNEoCfnPq a+9SQBcKXhRgKheMfuxqoEor5CKlP6jnlGNPsWlKJx52S65ZHH/NTOtJFcyH6YQf 35ihviVLNMW3Ka9yrw2pY4JWKlopBoe5etGnnyQe2nRzsPdTlT2eFVAJ0mgEc4C/ KRG4fh7n14MElvHLg0aszxV9TEjsjj5UUDWU+/4kWoKFkHfmjugOb0PcdeB52xPn 8KCI3AxLwUZuijhX4dhISvkGkAO0WLSnRdBrTGyXoh1JxDBPcMZH0B3GT/vDIwqc AfB9Bmm7SiuzgKVZu8QghRv/mvax6VAV9RjmMwwL53Zjmefg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk5cc2qb0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 10:21:27 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84870e7f498so562873b3a.3 for ; Thu, 23 Jul 2026 03:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784802087; x=1785406887; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=PSKeXsV8dg+pg/ChCFA5YKvPuaHbAUxkAi9j/OrnR/8=; b=ZtJoOIaB8ODIM0aUhCmRuJ9Pl72Vb9zUjKfJhxXXdBszkltE6f3IduopVzd2VWKHqz k8CE92v6JjTeBZea8O1ZsP2T6S5olECWyVNXIAfrny3G5RZU9rPtzE5+e9aA7gqvl58h J3cgoVMF8vxJB0s+TwByDdiUHClYPHPZ/g8Y1c6FTiudKhovJ/W6fLHNdFmTJnpC/1WP umqIpP0T575qFPC25NaC57SOOJEVCQKAB1cwQwJEmvjfymBOsy4xiTFmAATRw/acUwJm LcIPkK2oCX4NW9XymHzasNTovAlD/B18dZKOyMlxvjZPN/ZcBb3VjS4O9lkw+2eJjtE8 SRoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784802087; x=1785406887; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=PSKeXsV8dg+pg/ChCFA5YKvPuaHbAUxkAi9j/OrnR/8=; b=F7D5xeks1jlhcAlsYmfLoNYsCp92O4EK2GMnduHstmKUUsThFzwLMW5FpYWTh09kXR wfGxF14zu+Lbm+HoCtHH/0ZxVuUV8JysEratIs4N+re+t2nAh1pb/cCaAYJSzd8AAWQC 4fg9hBIVgQUX5prOXE4EXTxVeug1PhueMstwKhsCt863kmXmkkAXj5K2SJB0ObEqnXlH uYKoF5kclCJ9jpY7QsEUBX5C+rbEZBLqo4Ehp6YXXJ8lVdT0qjTk7XZEJ/AuYSLitRJG 0BfYeLgjb45fYRoqVtsQ/WinYgC1A2e5lNtV/z7LgG3kGlKoyDtPAiy4Un+dDFcmk03a fcog== X-Forwarded-Encrypted: i=1; AHgh+RrJXxl52x+uYzJQbXIPpr/kiDC+1+n81+VDX7DtNeO/jJmF8DiydCOgry1n2ByPG2JgLrQwUt2UVDPbRYw=@vger.kernel.org X-Gm-Message-State: AOJu0YytmmyTcNPtrzdHiaV2t20N9ze4pxuvrQO/CcCfdyG23PtWAYiy e5P/vRIn03CFi5KrU9p45vGXrKjwrWvvXeoovAe5OdJMYVJhKIdjMP37UGvNLYmfKsbCT8Z28i6 GJDU7xylbx4dtH0fsK6qpgM4VyZFKM0TqLIe7E/eZBf0NsfIsA5FHB+Efa/xrkOz+e+U= X-Gm-Gg: AR+sD11uV5V9tdxl3uguzu0fE4zZhBlJWrvK04eE0u5KS9XQK3su8P867n02IaK2CkV VupOrGtWjkBjJJ4ID5eiZNwHv2pXR6YfJpNyRnuiP1SHYcv2Pho4bILNRLowFUHFHRFVE7n6PxH +JRMHVuVJ4ZtmEMah9ugHNaCRYoeylHyDdmrTduoozvJAzD4/MRQtAAiSKjy3n44L0zQZkiyyj+ HiBy0z11U+lodCuOdo1r1GALAMBaACssoPAbZqXa2RaUx3lkk3C4/C4D8gdbe9gAfL2YczI7D5A RHWfxPNA9YCtP74iCBgOmC1Bnt/Dp0qcURJD2pR8aSDxSWG2wmpwJPfE5Ja4JGoKkciZb8WgYtg WzGSyb2jWH+312AQPKQdslubY+yIneeE= X-Received: by 2002:a05:6a00:bc10:b0:847:95a6:eb7b with SMTP id d2e1a72fcca58-84e2b8b37e9mr2919508b3a.33.1784802086693; Thu, 23 Jul 2026 03:21:26 -0700 (PDT) X-Received: by 2002:a05:6a00:bc10:b0:847:95a6:eb7b with SMTP id d2e1a72fcca58-84e2b8b37e9mr2919473b3a.33.1784802086224; Thu, 23 Jul 2026 03:21:26 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17285662sm2781395b3a.20.2026.07.23.03.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 03:21:25 -0700 (PDT) From: Sachin Kumar Garg Subject: [PATCH v4 0/3] media: qcom: iris: add multi slice support Date: Thu, 23 Jul 2026 15:51:12 +0530 Message-Id: <20260723-iris_multi_slice-v4-0-45f0a3fe7fce@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIABjrYWoC/23OQQrCMBAF0KtI1kaaSZs0rryHiKRxagfaRpNaF OndTQVRsJuBv5j3/5NFDISRbVdPFnCkSL5PIV+vmGtsf0ZOp5QZZKAyLRSnQPHY3dqBjrElh7x QuYZSW1MoydLbJWBN9ze5P6RcB9/xoQlov1AO5T80Ci64ASdBK2Gwqnc+xs31Zlvnu26Tzsw3F AcfHu/BI8wln216gQSecVMUWSVqrKSp/sl54ih/HBALjkyOPTklrCo1alxwpml6AVnZd0JOAQA A X-Change-ID: 20260716-iris_multi_slice-5647287a9563 To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Vedang Nagar , Stefan Schmidt , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784802081; l=4296; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=dR2BsPw2pnsRHBOo/jlv8TkOF1+nIU4AoH874uso198=; b=H4EFLcyC1E7ecOBPP8dUHHwx9uP89f74rJd5DvWYWLqjOEtGa8Q/OsULW5jcE5P9HCyEI76T2 lIcuCk1A18QBlFf62cXiIlkBZklXg1YHFDVJn5UqoCsOxHpFJLWr3cj X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-ORIG-GUID: FpDGi-8BMGDN4c8y0iLYIoTnJH7gZMQ2 X-Proofpoint-GUID: FpDGi-8BMGDN4c8y0iLYIoTnJH7gZMQ2 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEwMSBTYWx0ZWRfXwVE6a7ghrLfk kQL/zw8GLf/cbeakfqgtTaET5oyWjs8yK5+Z0ngpjU4vyGlMBvRgVea2+2/dVNsJA+6xMrdzi+o WwlRmyEogLLSntXQ4Ge2O1ySxjFUX3U= X-Authority-Analysis: v=2.4 cv=L/ItheT8 c=1 sm=1 tr=0 ts=6a61eb27 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=7Z090XU5ozNHmVG9x8gA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEwMSBTYWx0ZWRfX3SziS3rtuTT3 16yFbZbJwhBJv1FDKlSa6mr+FSIzWrMLjw19/l5hrKxiqwPjTE3C4RaB0yYulDuVgmBETtHEhmA ZYMnkZakCzxahJDa8LnlLxd3A3mIFdryfw6vC+AW0kQFplMBHK5n+P+jdushIIBovmHpCkbPZzX 25+WUfks5NJXn66hrQoSZEgJu/QXDdrOpAZViVePdAFsqJWwKsispwax53bH/29klRNxCq1SLAm RtkIc8dSOkixFqgRkgaE2DXuJ4p2V85aDvk8y9REpYb5BZvkRTk6r9Dfd99ki3K4bWD84X4ukfT Fm5hxzZ5OwgirOMkj8AlbGjnTiF7/gzKNlEEY6MWd474MHGhcVbv45XNKD0DUzZ5ftVLVoi4YQv dVRIBtTWJ5NRXvUM3uXNQec1gope/Rd1k+v59E8eJRWQWW6OpK2EmEtox8Fdt8hxc+uHwXZo8Y8 Q1aPlEp9lCMBVQf3XAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230101 This series adds support for multi-slice encoding in the Qualcomm Iris driver. Multi-slice mode allows encoding a single frame into multiple slices, which can improve error resilience and enable parallel processing. The feature supports two slice modes: - MAX_MB mode: slices are created based on macroblock count, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB - MAX_BYTES mode: slices are created based on byte size, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES Clients can enable slice mode using the V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control. Patch 1 is a prerequisite fix: iris_set_stage() computes a work_mode but never caches it back into inst->fw_caps[STAGE].value, leaving buffer-size and clock-frequency calculations based on a stale value. Patch 2 is another prerequisite fix: iris_set_stage() currently always selects STAGE_2 work mode for encoder sessions, but CBR rate control requires STAGE_1. This is fixed by forcing STAGE_1 when BITRATE_MODE is set to CBR. Patch 3 adds the multi-slice support itself for Iris HFI Gen2 based targets (qcs8300, sm8550 and other SM8550-derived targets). Support for HFI Gen1 targets will be added in a follow-up series. This series has been verified with GST level testing. Command used: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12, \ width=1280,height=720,framerate=30/1 ! v4l2h264enc output-io-mode=4 | capture-io-mode=4 extra-controls="controls,video_bitrate_mode=1, \ slice_partitioning_method=1,number_of_mbs_in_a_slice=460;" \ ! filesink location=/opt/test_enc.h264 Changes in v4: - Split out a new prerequisite patch (patch 1) to cache the computed work_mode into inst->fw_caps[STAGE].value in iris_set_stage(), since this fixes a pre-existing bug independent of the CBR change and needed its own Fixes tag. - Deduplicated the per-target slice capability limits that were previously repeated identically across platform_inst_cap_qcs8300 and platform_inst_cap_sm8550. Introduced struct platform_inst_slice_caps and moved it to iris_platform_data (one level up from platform_inst_caps), since all Iris HFI Gen2 targets share the same encoder capability table and hence the same slice limits; a single default_slice_caps_vpu3x instance is now referenced by all Gen2 platforms. - Link to v3: https://lore.kernel.org/r/20260721-iris_multi_slice-v3-0-adc61a687e7e@oss.qualcomm.com Changes in v3: - Patch 1 (force stage 1 work mode for CBR RC): cache the computed work_mode into inst->fw_caps[STAGE].value so buffer-size and clock-frequency calculations stay consistent with what is actually configured on firmware. - Patch 2 (multi-slice support): - Use inst->hfi_rc_type instead of the raw V4L2 BITRATE_MODE value when validating/deriving slice parameters, avoiding a mismatch between V4L2 and firmware rate-control enums. - Round up (instead of truncate) when computing the minimum MAX_MB and MAX_BYTES slice size floors, so the hardware's max-slices-per-frame limit is never exceeded. Changes in v2: - Added a prerequisite patch to force STAGE_1 work mode for CBR rate control on the encoder, required for multi-slice encoding to work correctly. - Addressed review comments on the multi-slice patch (updated commit subject and description). Signed-off-by: Sachin Kumar Garg --- Sachin Kumar Garg (3): media: iris: cache work mode after computing it in iris_set_stage media: iris: force stage 1 work mode for CBR RC on encoder media: iris: add support for multi_slice in iris encoder drivers/media/platform/qcom/iris/iris_ctrls.c | 84 ++++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 33 ++++++++- .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 + .../platform/qcom/iris/iris_platform_common.h | 16 +++++ .../media/platform/qcom/iris/iris_platform_vpu3x.c | 17 +++++ 6 files changed, 152 insertions(+), 1 deletion(-) --- base-commit: 42f83a32259a82c4481d3cccf560c3bfeb32c892 change-id: 20260716-iris_multi_slice-5647287a9563 Best regards, -- Sachin Kumar Garg