All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jack Ma <jack4it@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: David Ahern <dsahern@kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Jakub Kicinski <kuba@kernel.org>, Jack Ma <jack4it@gmail.com>
Subject: Re: [PATCH iproute2-next] ip nexthop: support fdb destination port
Date: Thu, 23 Jul 2026 01:43:48 +0000	[thread overview]
Message-ID: <20260723014348.1249-1-jack4it@gmail.com> (raw)
In-Reply-To: <20260722151904.GA3022830@shredder>

On Wed, Jul 22, 2026 at 06:19:04PM +0300, Ido Schimmel wrote:
> FWIW, I don't post iproute2 changes before the kernel changes are
> accepted. I put a link in the kernel cover letter to the repo where I
> have the iproute2 patches.

Thanks, understood.  The kernel cover letter links this iproute2 series,
and I posted it here only to make the userspace half easy to review
alongside -- it shouldn't be applied before the kernel attribute is
accepted.

> You need to perform this change in a separate patch. Example:
> https://lore.kernel.org/netdev/20260320140847.1730633-2-justin.iurman@6wind.com/

Done in v2.  The uapi header sync is now its own patch ("uapi: add
NHA_DST_PORT"), matching that example, with the ip nexthop changes in a
second patch.

> Missing update to the man page

Done in v2.  ip-nexthop.8 now documents dst_port in the synopsis and the
attribute description, with an example.

> Assuming we go with "dst_port", you can drop "fdb". Only the kernel will
> validate that "dst_port" is provided together with "fdb".

Done.  We did go with "dst_port" (NHA_DST_PORT) on the kernel side, so
usage is now a standalone "[ dst_port PORT ]" -- the "fdb" nesting is
gone and the kernel enforces the dst_port + fdb pairing.

> The convention here is "port %u ", not " port %u". I think you added it
> like that because there's a missing space in "fdb" above. Fix it while
> you are at it.

Done in v2.  Printing is now "dst_port %u " with the trailing space, and
I fixed the pre-existing missing space in the "fdb" print above it too.

v2:
  https://lore.kernel.org/netdev/20260723-b4-vxlan-fdb-port-iproute2-v2-0-9012ac01b49e@gmail.com/

Thanks,
Jack

      reply	other threads:[~2026-07-23  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  3:21 [PATCH iproute2-next] ip nexthop: support fdb destination port Jack Ma
2026-07-22 15:19 ` Ido Schimmel
2026-07-23  1:43   ` Jack Ma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723014348.1249-1-jack4it@gmail.com \
    --to=jack4it@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.