From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EC9283FDD for ; Thu, 23 Jul 2026 01:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771281; cv=none; b=aL65QXzp8BBS00Bf7bHrSD7m0pk5CpI5fVmgTrcJ2GdYsR1fcoavGqWSdpkYjCY5QQodeBzYDu367camDu2ZsVnljaq+LTBJL11HQT94Q9KaYhLD7yxjD8DlcWgZ5CxgYuyg+lY9MszpG9LPDAbQi4x0G8bHl65lSAFsx6M/Qlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771281; c=relaxed/simple; bh=WGX6mHAknagnPFkQaYfu1o9VprdmtnE/DRcOhGUoKR8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=hF+9s4EaPEQn0HM14LTE5ZJFv8K0FJdwAiCbxX2gn8C38TBRvROC/IQbEUoXTePN+GiZUTie0VM3zPtL9CnCKydJ4cmqXN/7U3e2GurpRy9jjC4zU8p1fIJeoshakbmrNYT1Zs7JIzVL+cBmO/Gm0N18oMUCX3DOvk+eWDVWJi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JBvjLr3n; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JBvjLr3n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 549281F000E9; Thu, 23 Jul 2026 01:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784771279; bh=FgHe+npIqS2rAfjj6XicyzwnNjdSW1SvMFF7N8eDgH8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JBvjLr3n3VMNuG7/MSeytoSINk8IFf9kqXqGL83pJyhNVObO0Bg6UjaKcLThOvj0P +eTey9fqxzanEM9mCy9mNi9OBlYSNGCJ4uWeCoKjzEPb6gX8Mr1raG1o8E2EQ3PXfY obQs4cRrsDP2zkeSwlt/fxVksIIrQl5T3R+KZBa/rayzt0PRrO8+hoLbeLSsYCFfx/ Z6e8N8xYIbmP1tObpqn/+IgOn7PuL4qtIliVWZ5UlqB0jweLOOM0M9ss/v6U1/wUwD Paqx+yyUb0qMF4lmaurQZiGjee7kHhkwvF9xCIfDJPis/H/OSRec9E0J8Aj3kMVug3 qdhdZ50WTMjcw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v9 11/61] drm/bridge: Add bridge ops for source-side HDMI 2.0 scrambling Reply-To: sashiko-reviews@lists.linux.dev To: "Cristian Ciocaltea" Cc: dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev In-Reply-To: <20260723-dw-hdmi-qp-scramb-v9-11-4fb12ea22ac9@collabora.com> References: <20260723-dw-hdmi-qp-scramb-v9-0-4fb12ea22ac9@collabora.com> <20260723-dw-hdmi-qp-scramb-v9-11-4fb12ea22ac9@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 23 Jul 2026 01:47:58 +0000 Message-Id: <20260723014759.549281F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Missing implementation of HDMI 2.0 scrambler callbacks in drm_brid= ge_connector causes initialization failure -- --- Patch [11]: [PATCH v9 11/61] drm/bridge: Add bridge ops for source-side= HDMI 2.0 scrambling --- commit 449aac531f177fb10d98b7aac7653c2b23b627e6 Author: Cristian Ciocaltea drm/bridge: Add bridge ops for source-side HDMI 2.0 scrambling This commit adds hdmi_scrambler_enable and hdmi_scrambler_disable callbacks to drm_bridge_funcs. This enables bridges advertising HDMI 2.0 to configure source-side scrambling for modes exceeding 340 MHz. > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 727eeb94119a5..348ddbe41dec5 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -561,6 +561,41 @@ struct drm_bridge_funcs { > const struct drm_display_mode *mode, > unsigned long long tmds_rate); > =20 > + /** > + * @hdmi_scrambler_enable: > + * > + * Enable source-side scrambling and the high TMDS clock ratio for the > + * mode currently being applied. > + * > + * This only programs the source side. Sink-side SCDC configuration is > + * handled by the HDMI connector helpers. > + * > + * Mandatory for bridges that set the DRM_BRIDGE_OP_HDMI flag in their > + * &drm_bridge->ops and advertise HDMI_VERSION_2_0 or later via > + * &drm_bridge->supported_hdmi_ver; unused otherwise. > + * > + * Returns: > + * 0 on success, a negative error code otherwise. > + */ > + int (*hdmi_scrambler_enable)(struct drm_bridge *bridge); > + > + /** > + * @hdmi_scrambler_disable: [Severity: High] Will bridge drivers adopting these new callbacks fail to probe? Looking at drm_bridge_connector_init(), the wrapper fails to map these newly added bridge callbacks to the connector's hdmi_funcs before calling=20 drmm_connector_hdmi_init(): ret =3D drmm_connector_hdmi_init(drm, connector, &drm_bridge_connector_funcs, &bridge_connector->hdmi_funcs, connector_type, ddc); Because these new bridge ops are not mapped over to=20 bridge_connector->hdmi_funcs, the core DRM HDMI initialization in=20 drmm_connector_hdmi_init() will see them as missing and unconditionally=20 fail with -EINVAL for HDMI 2.0+ devices: if (hdmi_funcs->supported_hdmi_ver >=3D HDMI_VERSION_2_0) { if (!hdmi_funcs->scrambler_enable || !hdmi_funcs->scrambler_disable) { drm_err(dev, "Scrambler callbacks missing for HDMI 2.x\n"); return -EINVAL; } } Should drm_bridge_connector_init() be updated to populate .scrambler_enable= =20 and .scrambler_disable from these new bridge ops to prevent initialization= =20 failures? > + * > + * Disable source-side scrambling and the high TMDS clock ratio. > + * > + * This only programs the source side. Sink-side SCDC configuration is > + * handled by the HDMI connector helpers. > + * > + * Mandatory for bridges that set the DRM_BRIDGE_OP_HDMI flag in their > + * &drm_bridge->ops and advertise HDMI_VERSION_2_0 or later via > + * &drm_bridge->supported_hdmi_ver; unused otherwise. > + * > + * Returns: > + * 0 on success, a negative error code otherwise. > + */ > + int (*hdmi_scrambler_disable)(struct drm_bridge *bridge); > + > /** > * @hdmi_clear_avi_infoframe: > * --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260723-dw-hdmi-qp= -scramb-v9-0-4fb12ea22ac9@collabora.com?part=3D11